Spearhead: Add dynamic Dark Mode support for Editor #3030
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When initializing the editor determine the background color and optionally enabled "dark editor support" based on a luminocity calculation of that background color This is a Work in Progress
pbking
changed the title
scruffian
reviewed
Jan 14, 2021
| */ | ||
|
|
||
| // domReady( function() { | ||
| setTimeout(()=>{ |
There was a problem hiding this comment.
Is there something we could listen to/wait for rather than just waiting 3 seconds?
|
I tried a different approach here: WordPress/gutenberg#28233 |
|
Closing in deference of Gutenberg change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
When initializing the editor determine the background color and
optionally enabled "dark editor support" based on a luminocity
calculation of that background color
This is a Work in Progress
Related issue(s):
This is related to #2905 which should be retested with this fix.