Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Varia: Fix cover text color over clear backgrounds. #4086

Merged
merged 4 commits into from
Jun 24, 2021

Conversation

andres-blanco
Copy link
Contributor

@andres-blanco andres-blanco commented Jun 22, 2021

Changes proposed in this Pull Request:

When you add a cover block with a white (or clear) background the font color is also white and you cannot see what you write.

This change makes the necessary changes so that the cover font colors are picked up from the customizer palette in Colors & Backgrounds > Text Color.

This fix applies to Varia and all its child themes.

Before After
image image

The changes are in the sass files in the Varia template:

  • varia/sass/blocks/utilities/_style.scss
  • varia/sass/blocks/utilities/_editor.scss
  • varia/sass/blocks/cover/_style.scss
  • varia/sass/blocks/cover/_editor.scss

All the other changes are auto-generated following this instructions: pNEWy-daO-p2

This also fixes the alignment of the search block on the Rivington theme. In this commit: 87dbce4 changes where added directly to the css files instead of the corresponding sass file. When I rebuilt Varia children the changed got removed.

SVN: D63216-code

Testing instructions

  1. Clone this repo git@github.com:Automattic/themes.git
  2. Push this repo to your sandbox using ./sandbox.sh push (more instructions in README.md https://github.com/Automattic/themes)
  3. Verify on your sandbox that when you add a cover block with a light background-color the paragraph inside is visible. This only applies to Varia and its child themes. Here is a list of the themes affected:
Barnsbury
Dalston
Mayland
Rivington
Maywood
Balasana
Shawburn
Alves
Exford
Rockfield
Stratford
Coutoire
Morden
Stow
Hever
Leven
Varia

Related issue(s):

#3483

@andres-blanco andres-blanco merged commit 47152fe into trunk Jun 24, 2021
@andres-blanco andres-blanco deleted the fix/cover-text-color branch June 24, 2021 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant