Varia: Fix cover text color over clear backgrounds. #4086
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
When you add a cover block with a white (or clear) background the font color is also white and you cannot see what you write.
This change makes the necessary changes so that the cover font colors are picked up from the customizer palette in
Colors & Backgrounds > Text Color
.This fix applies to Varia and all its child themes.
The changes are in the sass files in the Varia template:
varia/sass/blocks/utilities/_style.scss
varia/sass/blocks/utilities/_editor.scss
varia/sass/blocks/cover/_style.scss
varia/sass/blocks/cover/_editor.scss
All the other changes are auto-generated following this instructions: pNEWy-daO-p2
This also fixes the alignment of the search block on the Rivington theme. In this commit: 87dbce4 changes where added directly to the css files instead of the corresponding sass file. When I rebuilt Varia children the changed got removed.
SVN: D63216-code
Testing instructions
git@github.com:Automattic/themes.git
./sandbox.sh push
(more instructions in README.md https://github.com/Automattic/themes)Related issue(s):
#3483