POC: remove customizer options from Blockbase children via filters #5435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaggieCabrera
added
the
[Theme] Skatepark
mikachan
approved these changes
Feb 2, 2022
|
I think we should hold off on this until WordPress/gutenberg#38442 merges |
|
I agree, but I think we should add the filters to Blockbase for the future. |
MaggieCabrera
changed the title
MaggieCabrera
added
[Theme] Blockbase
and removed
[Theme] Skatepark
|
Since Skatepark is no longer a Blockbase child Imma gonna close this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
This PR removes the customizer options on Skatepark via filters on Blockbase. To test this check that everything is working as intended (fonts are showing correctly, colors can change via the FSE only) and there's no customizer option under the Appearance menu
context: pNEWy-eGS-p2#comment-54234