-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip loading the Learning Mode styles when Sensei is not available #7031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donnapep
reviewed
Apr 21, 2023
donnapep
reviewed
Apr 21, 2023
donnapep
reviewed
Apr 21, 2023
m1r0
reviewed
May 2, 2023
donnapep
approved these changes
May 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! When do you think we should consider removing the learning-mode.css
file altogether? Perhaps with the next major release after the next one? If so, perhaps we could add a note in the file about it so we don't forget.
donnapep
changed the title
Course: Skip the learning mode style when sensei is not available
Skip the learning mode style when sensei is not available
Jun 1, 2023
donnapep
changed the title
Skip the learning mode style when sensei is not available
Skip the learning mode style when Sensei is not available
Jun 1, 2023
donnapep
changed the title
Skip the learning mode style when Sensei is not available
Skip loading the Learning Mode styles when Sensei is not available
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially solve Review spacings and alignment on the course theme#6834
Changes proposed in this Pull Request:
Testing instructions
learning-mode.css
is not loadedlearning-mode.css
is loaded.Context
The sensei team is delegating the responsibility to load the learning mode style to the plugin, instead of the handle it on the theme. It will help us to avoid coupling between the theme version and the plugin version.