Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add types for the other ways of using enquirer #1395

Merged
merged 3 commits into from
Jun 2, 2023

Conversation

abdullah-kasim
Copy link
Contributor

@abdullah-kasim abdullah-kasim commented Jun 2, 2023

Description

Add types for enquirer. I copy-pasted this off enquirer/enquirer#307 and sprinkled some salt in it so that prompt<T> works properly.

I agree with the previous PR, just move to inquirer is the better way. Apparently we were on inquirer but moved to enquirer to have working autocomplete. Which is weird - inquirer already has autocomplete through a plugin

Steps to Test

  1. Ensure that tests pass. This is just a type change.

Copy link
Member

@sjinks sjinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥🔥🔥

@abdullah-kasim
Copy link
Contributor Author

I need to fix something.

@sonarcloud
Copy link

sonarcloud bot commented Jun 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@abdullah-kasim abdullah-kasim merged commit a4ccaea into develop Jun 2, 2023
14 checks passed
@abdullah-kasim abdullah-kasim deleted the fix/type-errors-with-enquirer branch June 2, 2023 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants