Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix Cannot read properties of undefined in generate-docs.js #1794

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

sjinks
Copy link
Member

@sjinks sjinks commented Apr 24, 2024

Description

/home/runner/work/vip-cli/vip-cli/helpers/generate-docs.js:89
			while ( ! lines[ lineIx ].trim().startsWith( '$' ) ) {
			                          ^

TypeError: Cannot read properties of undefined (reading 'trim')
    at parseOutput (/home/runner/work/vip-cli/vip-cli/helpers/generate-docs.js:89:30)
    at processCommand (/home/runner/work/vip-cli/vip-cli/helpers/generate-docs.js:118:23)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async processCommand (/home/runner/work/vip-cli/vip-cli/helpers/generate-docs.js:126:24)
    at async main (/home/runner/work/vip-cli/vip-cli/helpers/generate-docs.js:144:17)

Node.js v18.20.2

This PR fixes that error.

Ref: https://github.com/Automattic/vip-cli/actions/runs/8822638714/job/24221295810

Pull request checklist

New release checklist

Steps to Test

Check out the PR and verify that node helpers/generate-docs.js works as expected.

@sjinks sjinks added [Type] Bug Something isn't working [Status] Needs Review labels Apr 24, 2024
@sjinks sjinks self-assigned this Apr 24, 2024
Copy link
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link

sonarcloud bot commented Apr 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sjinks sjinks merged commit 450e425 into trunk Apr 24, 2024
17 checks passed
@sjinks sjinks deleted the fix/gen-docs branch April 24, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants