Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for missing settings and change the allowedChildren to allowedBlocks #24

Merged
merged 9 commits into from
Aug 28, 2023

Conversation

ingeniumed
Copy link
Contributor

@ingeniumed ingeniumed commented Aug 23, 2023

Description

  • Add support for settings that didn't work before. This includes typography, color.gradients, spacing, etc. Only duotone is left and that's been documented in the limitations. For the MVP, that's fine as it's proving to be tricky to resolve.
  • Add more examples to show how the missing properties would work.
  • Switch allowedChildren to allowedBlocks, and upgrade the version from 0.1.0 to 0.2.0 to account for this. Thanks @alecgeatches for pointing this out in the previous PR.
  • Re-order the README to make the flow better for new plugin users.

Note: While this is a breaking change, given we are in beta its fine. We don't need to add support for backward versions that are a part of the beta.

Fixes #22
Fixes #23

Steps to Test

  • Run the tests
  • Use the new example in your governance-rules.json and ensure that everything works as expected.

@ingeniumed ingeniumed marked this pull request as ready for review August 23, 2023 06:58
Copy link
Contributor

@alecgeatches alecgeatches left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 This works great! The governance rules could handle every setting I tried to throw at them.

While testing I noticed some allowedBlocks behavior and related issues with the core/list block documented in #30. However, I don't think those are related to the changes here.

Great job figuring this out!

@ingeniumed ingeniumed merged commit e74944e into trunk Aug 28, 2023
5 checks passed
@ingeniumed ingeniumed deleted the add/support-for-missing-settings branch August 28, 2023 00:54
@ingeniumed
Copy link
Contributor Author

Fixes #26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change allowedChildren to allowedBlocks Add typography support
2 participants