Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix login bug when trying to logout #222

Merged
merged 3 commits into from
Dec 21, 2018
Merged

Conversation

elazzabi
Copy link
Member

Currently if a user wants to logout and the user isn't logged in, a login prompt will be displayed.

This fixes that behavior by skipping the login if the command is logout

mjangda
mjangda previously approved these changes Dec 20, 2018
Copy link
Member

@mjangda mjangda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works well.

Noted some suggestions to rename variables for clarity (boolean vars should ideally always start with is/has/etc.

src/bin/vip.js Outdated Show resolved Hide resolved
src/bin/vip.js Outdated Show resolved Hide resolved
src/bin/vip.js Outdated Show resolved Hide resolved
Co-Authored-By: elazzabi <elazzabi.ahmed@gmail.com>
@elazzabi elazzabi merged commit e7e4ce9 into master Dec 21, 2018
@elazzabi elazzabi deleted the fix/login-before-logout branch December 21, 2018 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants