Fix not allowed page when clicking Set up WooPayments from Core and account is already onboarded #7652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.44 MB ℹ️ View Unchanged
|
vladolaru
approved these changes
Nov 7, 2023
|
Regarding tech debt, @oaratovskyi, I think we should have an issue for normalizing and reducing the redirect logic, so we don't get to pile on more conditional branches to the logic. For that issue, we should strive to have a stable, catch-all logic that would prevent any other such issues in the future (no more ending up on pages with "Sorry you are not allowed"). WDYT? |
daquinons
approved these changes
Nov 7, 2023
There was a problem hiding this comment.
Thanks Oleks! I've tested it with the builder (test) account but I imagine this issue would also be occurring with live accounts, so this is perfect.
I do agree with @vladolaru, this seems like a painful area where we tend to have issues and have to revisit quite often. Can you create a tech debt issue in component onboarding pointing to this change and conversation to get the context? 💯
…-for-completed-accounts' into fix/7625-fix-setup-payments-task-for-completed-accounts
|
Thanks mates for your reviews! I made a fix to the bug spotted by e2e tests, could you please run the tests one more time? 🙏 |
Sure thing! I'll create one and link to this issue. |
|
Tested again, @oaratovskyi! Works as expected. Thanks for the fix. |
|
Created #7654 that will address redirects logic |
|
Created #7655 that will improve statuses logic |
oaratovskyi
deleted the
fix/7625-fix-setup-payments-task-for-completed-accounts
branch
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7625
Description
Merchants currently observe an issue with Set up WooPayments task: when account is fully onboarded, the link redirect them to
payments/onboardingwhich results in Not allowed page errorChanges proposed in this Pull Request
I decided that the best experience for merchants will be to get redirected to
payments/overviewpage if the account is fully onboarded. I'll create a tech debt issue for that if that sounds good!Important
Tests are not added since there is no tests for
maybe_handle_onboardingfunction. Creating tests for it seems like out of scope for this PR.Testing instructions
developbranch)fix/7625-fix-setup-payments-task-for-completed-accountspayments/overviewBonus: test that Set up WooPayments link works well when we don't have onboarded account.
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge