Disable WooPay for suspended and rejected accounts - Take 2 #8942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.25 MB ℹ️ View Unchanged
|
Also removes active webhooks if the account is suspended or rejected
account is restriced
Fixes a fatal error when clearing the account data cache. In this PR we call `WC_Payments::get_account_service()->is_account_rejected()` to know if the account is rejected. This method will get the data from Stripe and the `WC_Payments_Account->get_cached_account_data()` will be called. Then the action `woocommerce_payments_account_refreshed` will be fired. The `Compatibility_Service` class is registering a hook for that action. https://github.com/Automattic/woocommerce-payments/blob/trunk/includes/class-compatibility-service.php#L41 Then `Compatibility_Service->get_compatibility_data()` is called. Which calls the `get_permalink()` function. This function internally calls to `_get_page_link` which uses `$wp_rewrite` global but at the time it’s not defined resulting in a PHP fatal error. This commit fixes it. Note that the request to the server is not done on every page refresh, only after clearing the account cache contents.
…er_review` We are already checking if the account is rejected or under review in the `WC_Payments_Features::is_woopay_eligible()` method.
Fixes a fatal PHP error that happens when the account cache is expired. Check #8942 for more details.
asumaran
force-pushed
the
as-disable-woopay-rejected-suspended-accounts
branch
from
f8c9c4b
to
270d47c
Compare
ricardo
approved these changes
Jun 14, 2024
There was a problem hiding this comment.
The fix tests well, but I was able to reproduce the error only when moving self::maybe_register_woopay_hooks() and self::maybe_display_express_checkout_buttons() out of setup_theme, but not the last 2 methods.
Also, please check my comment about WooPay_Order_Status_Sync::remove_webhook(); before merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/Automattic/woopay/issues/2641
Original PR (#8857) introduced some fatal PHP errors that others also saw it (p1717672645619179-slack-CGGCLBN58).
I decided to revert the PR in #8912 to find and fix the error.
Changes in this PR are the same as #8857 except for the last commit which contains the fix to the fatal errors.
Given that the changes were already reviewed in #8857 I'll focus on explaining the fix.
woocommerce_payments_account_refreshedis fired (ref)Compatibility_Serviceclass already registered a callback for that hook. (ref)update_compatibility_data()method call,get_permalink()will be called. (ref)get_permalink()callsget_page_link()which calls_get_page_link()which uses the$wp_rewriteglobal variable (ref).plugins_loadedaction there's no$wp_rewriteglobal defined. Sinceplugins_loadedis fired before$wp_rewriteis defined. That explains the error:setup_theme.Testing instructions
setup_themehook each individual line and refreshing the page after 10 seconds. You should see a different fatal error for each line.self::maybe_register_woopay_hooks();self::maybe_display_express_checkout_buttons();self::maybe_init_woopay_direct_checkout();self::maybe_enqueue_woopay_common_config_script( WC_Payments_Features::is_woopay_direct_checkout_enabled() );<-- hereWC_Payments_Features::is_woopay_direct_checkout_enabled()is what triggers the error.npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge