Add specificity to root selector to avoid conflicts in Calypsoified wp-admin. #1549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanReyLop
reviewed
Dec 3, 2018
assets/stylesheets/_components.scss
Outdated
| @@ -33,6 +33,7 @@ | |||
| @import 'components/screen-reader-text/style'; | |||
| @import 'components/segmented-control/style'; | |||
| @import 'components/spinner/style'; | |||
| @import 'components/token-field/style'; | |||
There was a problem hiding this comment.
This shouldn't be needed, the stylesheet for token-field is already included as "modular CSS" (see here).
There was a problem hiding this comment.
If specificity is a problem, you should add the .wp-core-ui.wp-admin prefix to here.
There was a problem hiding this comment.
Fixed in 9d1f95d. Thank you!
… wp-calypso style wrapper.
DanReyLop
reviewed
Dec 5, 2018
| @@ -1,6 +1,6 @@ | |||
| @import 'shared/utils'; | |||
|
|
|||
| .wcc-root { | |||
There was a problem hiding this comment.
Sorry I missed this. This solution would break horribly in Store-in-dotcom, because Calypso doesn't add the wp-admin wp-core-ui classes to the </body>, so no CSS would be applied.
Edit: Nevermind, I still have vacation brain, this won't be loaded in Calypso at all. Disregard.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR seeks to fix style conflicts when running within a "Calypsoified"
/wp-admin. See: p58i-7nL-p2 (#comment-40377)To test:
npm run dist