Prevents a PHP fatal error that occurs when the cart contains a renewal order item that no longer exists #544
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #537
Description
Inside subscriptions we have code that makes sure that if a cart contains a renewal item, we should make sure we're honoring the price of the subscription/renewal order and not the new price if it's been updated etc.
When the cart contains an item that no longer exists on the order, we get the following fatal errors that occur:
This PR fixes this issue by making sure we're only honoring subscription prices on cart items that still belong to the order/subscription. If the cart item cannot be found on the order, we simply return the default.
How to test this PR
trunk
if you refresh the page and you should see the above fatal errorsProduct impact