Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

have a filter to defer signature verification #435

Merged
merged 8 commits into from
Nov 11, 2023
Merged

have a filter to defer signature verification #435

merged 8 commits into from
Nov 11, 2023

Conversation

pfefferle
Copy link
Member

@pfefferle pfefferle commented Sep 15, 2023 •
edited
Loading

With the filter, you can defer (bypass) the signature verification based on the request parameters.

Maybe a quick win for #554

Proposed changes:

Other information:

  • Have you written new tests for your changes, if applicable?

Testing instructions:

  • Go to '..'

@pfefferle
have a const to deactivate signature verification
5e991c4 
but please deactivate ACTIVITYPUB_SIGNATURE_VERIFICATION only for debugging purposes!
@mediaformat
Copy link
Collaborator

I wonder if this should be paired with something like WP_DEBUG_DISPLAY, to make it really obvious that this is active and debug related.

@pfefferle
Copy link
Member Author

Good point!

@pfefferle pfefferle changed the title have a const to deactivate signature verification have a filter to bypass signature verification Nov 9, 2023
@pfefferle pfefferle changed the title have a filter to bypass signature verification have a filter to defer signature verification Nov 10, 2023
@pfefferle
Copy link
Member Author

I changed it to a filter, to also address #554

What do you think @mattwiebe and @mediaformat ?

@mediaformat
Copy link
Collaborator

LGTM

mattwiebe
mattwiebe approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@mattwiebe mattwiebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Hope it'll help us get to the bottom of some problems.

@pfefferle pfefferle merged commit 6810884 into master Nov 11, 2023
19 checks passed
@pfefferle pfefferle deleted the add/signature-verification-option branch November 11, 2023 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattwiebe mattwiebe mattwiebe approved these changes

@mediaformat mediaformat Awaiting requested review from mediaformat

@jeherve jeherve Awaiting requested review from jeherve

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pfefferle @mediaformat @mattwiebe