Profiles: Update followers when profile fields change
#542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattwiebe
force-pushed
the
add/profile-update-pings
branch
from
38ab84f
to
af3e61c
Compare
mediaformat
reviewed
Nov 8, 2023
| // profile updates for user options | ||
| if ( ! is_user_type_disabled( 'user' ) ) { | ||
| \add_action( 'updated_user_meta', array( self::class, 'user_update' ), 10, 3 ); | ||
| // @todo figure out a feasible way of updating the header image since it's not unique to any user. |
There was a problem hiding this comment.
@mattwiebe @pfefferle I have a Profile Banner code stub, which could live inside this plugin, but also makes sense as an independent block for Block Theme use. Any thoughts?
There was a problem hiding this comment.
@mediaformat sounds interesting! Do you have a public repo with the code?
|
When I tested this on dotcom it did not necessarily seem like it worked, but that may have been a result of our other troubles there. I will try again now that we fixed our problems with the application user there before merging this. |
pfefferle
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we are at the mercy of remote servers refreshing profile data on their schedule. This PR will instead send an
UpdateActivity to all Follower inboxes whenever an update to a relevant option or user meta is updated.Proposed changes:
Other information:
Testing instructions:
This is completely untested so far.