Comment Federation#550
Merged
Merged
Conversation
fix #122 thanks and props @skysarwer
Member
Author
|
@mediaformat this is a working first version. I would love to get your feedback on this! |
props @Menrath for the feedback and the idea!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The initial PR by @mediaformat is already so complex that it is hard to refactor things and make other things work, so I would love to re-start a PR to get through all changes step by step.
Starting with:
Open Questions:
Proposed changes:
Other information:
Testing instructions: