Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocks: add alt text to avatars #579

Merged
merged 2 commits into from Nov 27, 2023
Merged

Conversation

mattwiebe
Copy link
Contributor

@mattwiebe mattwiebe commented Nov 27, 2023

Fixes #572

Proposed changes:

  • adds alt text to avatar in Follow Me and Followers blocks

Other information:

  • Have you written new tests for your changes, if applicable?

Testing instructions:

  • Go to '..'

Copy link
Member

@pfefferle pfefferle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattwiebe mattwiebe changed the title Follow Me: add alt text to avatar Blocks: add alt text to avatars Nov 27, 2023
@mattwiebe mattwiebe merged commit cffff80 into master Nov 27, 2023
20 of 21 checks passed
@mattwiebe mattwiebe deleted the update/follow-me-alt-text branch November 27, 2023 20:35
@cybeardjm
Copy link

A quick question, indirectly connected to this issue: when testing on the Followers block, did it crash in edit or view mode as it does on both my blogs (see issue #571)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Add [alt] attribute to image on "follow me" block
3 participants