-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A better default content handling based on the Object Type #661
Conversation
if using that feature for ActivityPub
@janboddez I would love to get your feedback on this. I plan to remove the shortcodes in the near future and have a better default setup. |
Ha, this is interesting, I'll try to have a look later. Somewhat off-topic (because it relates to what I am doing): I personally still use post types. However, I might end up mapping these to formats so I can support both Note and Article. 🤔 Currently everything "is" a Note and I filter the content (title or no title) based off the post type. Not sure if a filter to override/bypass the type would be handy? Guessing you can also end up with "too many" filters this way. And ... only devs use them, they're mostly useless to everyone else. Maybe having (only) the entire object filterable would be a nice alternative? I currently use Back on-topic: I would love it if Notes (if they correspond with status or aside post formats) did not have a title, but Articles did. Not sure how this could work though, given that nearly everybody is probably converting Articles to Notes, and that their template is set up for posts (i.e., Articles). Eventually getting rid of the template altogether and just having a solid default based on post formats sounds really nice, though. Someone with PHP knowledge could always use the content filter to fine-tune more. |
Following up from #678: It might be interesting to offer a variety of different types, that are compatible with existing Fediverse platforms:
It also might be useful to offer the ability to customize the output for each type, similar to what we already have. For a Podcast post type, for example, maybe it makes the most sense to offer a |
Does that mean, that you propose to send different versions of the same post depending on the receiver platform? |
That's an interesting idea, a concept I have thought about before, but no. Each WordPress post would federate out to all followers as the designated type specified in WordPress-ActivityPub settings. If the schema maps up to something a follower can read, it will be up to the follower's platform to attempt to render it. It's the type is unsupported and the platform doesn't fall back to simply rendering a note with a link, the platform instead will not render anything. In other words, if I post an |
Ok, that's what the post is about, but I am not sure about Audio/Video/Image... initially I thought about mapping these types to the corresponding ActivityPub type... But an Audio-Post is not really an Audio Activity, it is more a Note with an Audio Attachment... |
That's okay, as long as we can choose a It was more of a suggestion that we should try to support more activity types than |
@Menrath is also already working on Events btw.: https://github.com/Automattic/wordpress-activitypub/blob/master/includes/activity/extended-object/class-event.php |
Maybe we could map attachments to their corresponding Activity Type?!? https://github.com/Automattic/wordpress-activitypub/blob/master/includes/transformer/class-attachment.php |
Yeah, that looks good to me! |
Mastodon improved it's default handling of non Note (or unknown) Activities, so we should prepare to remove the shortcodes.
Proposed changes:
/cc @Menrath
Other information:
Testing instructions: