Prep for calypso

.eslintignore

@@ -6,6 +6,7 @@
 node_modules/
 !.eslintrc.js
 /server/devdocs/search-index.js
+/packages/calypso-codemods/tests
 
 # Built packages
 /packages/*/dist/

package.json

@@ -332,6 +332,7 @@
 		"babel-jest": "24.9.0",
 		"babel-plugin-dynamic-import-node": "2.3.0",
 		"babel-plugin-transform-react-remove-prop-types": "0.4.24",
+		"calypso-codemods": "file:./packages/calypso-codemods",
 		"chai": "4.2.0",
 		"chai-enzyme": "1.0.0-beta.1",
 		"check-node-version": "3.3.0",

packages/calypso-codemods/.eslintrc.js

@@ -0,0 +1,6 @@
+module.exports = {
+	rules: {
+		'import/no-nodejs-modules': 'off',
+		'import/no-extraneous-dependencies': [ 'error', { packageDir: __dirname } ],
+	},
+};

packages/calypso-codemods/README.md

@@ -1,8 +1,5 @@
 # Calypso Codemods
 
-[![Build Status](https://travis-ci.org/Automattic/calypso-codemods.svg?branch=master)](https://travis-ci.org/Automattic/calypso-codemods)
-
-
 ## What are codemods?
 
 Code modification scripts, also known as codemods, are transformation scripts that can simultaneously modify multiple files with precision and reliability. Codemods were popularized by [Facebook's engineering team](https://medium.com/@cpojer/effective-javascript-codemods-5a6686bb46fb) and depends greatly on Facebook's [jscodeshift](https://github.com/facebook/jscodeshift) library, which wraps over a library named [recast](https://github.com/benjamn/recast) (author of which is associated with the [Meteor](https://www.meteor.com/) project).

packages/calypso-codemods/api.js

@@ -3,69 +3,74 @@
 /**
  * External dependencies
  */
-const fs = require("fs");
-const path = require("path");
-const child_process = require("child_process");
+const fs = require( 'fs' );
+const path = require( 'path' );
+const child_process = require( 'child_process' );
 
 /**
  * Internal dependencies
  */
-const config = require(path.join(__dirname, "config"));
-const transformsDir = path.join(__dirname, "./transforms");
+const config = require( path.join( __dirname, 'config' ) );
+const transformsDir = path.join( __dirname, './transforms' );
+
+const jscodeshiftBin = require( 'module' )
+	.createRequireFromPath( require.resolve( 'jscodeshift' ) )
+	.resolve( require( 'jscodeshift/package.json' ).bin.jscodeshift );
 
 function getLocalCodemodFileNames() {
 	const jsFiles = fs
-		.readdirSync(transformsDir)
-		.filter(filename => filename.endsWith(".js"))
-		.map(name => path.basename(name, ".js")); // strip path and extension from filename
+		.readdirSync( transformsDir )
+		.filter( filename => filename.endsWith( '.js' ) )
+		.map( name => path.basename( name, '.js' ) ); // strip path and extension from filename
 
 	return jsFiles;
 }
 
 function getValidCodemodNames() {
-	return [...getLocalCodemodFileNames(), ...Object.getOwnPropertyNames(config.codemodArgs)]
-		.map(name => "- " + name)
+	return [ ...getLocalCodemodFileNames(), ...Object.getOwnPropertyNames( config.codemodArgs ) ]
+		.map( name => '- ' + name )
 		.sort();
 }
 
-function generateBinArgs(name) {
-	if (config.codemodArgs.hasOwnProperty(name)) {
+function generateBinArgs( name ) {
+	if ( Object.prototype.hasOwnProperty.call( config.codemodArgs, name ) ) {
 		// Is the codemod defined in the codemodArgs object?
-		return config.codemodArgs[name];
+		return config.codemodArgs[ name ];
 	}
 
-	if (getLocalCodemodFileNames().includes(name)) {
-		return [`--transform=${transformsDir}/${name}.js`];
+	if ( getLocalCodemodFileNames().includes( name ) ) {
+		return [ `--transform=${ transformsDir }/${ name }.js` ];
 	}
 
-	throw new Error(`"${name}" is an unrecognized codemod.`);
+	throw new Error( `"${ name }" is an unrecognized codemod.` );
 }
 
-function runCodemod(codemodName, transformTargets) {
-	const binArgs = [...config.jscodeshiftArgs, ...generateBinArgs(codemodName), ...transformTargets];
+function runCodemod( codemodName, transformTargets ) {
+	const binArgs = [
+		...config.jscodeshiftArgs,
+		...generateBinArgs( codemodName ),
+		...transformTargets,
+	];
 
-	process.stdout.write(`\nRunning ${codemodName} on ${transformTargets.join(" ")}\n`);
+	process.stdout.write( `\nRunning ${ codemodName } on ${ transformTargets.join( ' ' ) }\n` );
 
-	const binPath = path.join(".", "node_modules", ".bin", "jscodeshift");
-	const jscodeshift = child_process.spawnSync(binPath, binArgs, {
-		stdio: ["ignore", process.stdout, process.stderr],
-	});
+	child_process.spawnSync( jscodeshiftBin, binArgs, {
+		stdio: [ 'ignore', process.stdout, process.stderr ],
+	} );
 }
 
-function runCodemodDry(codemodName, filepath) {
+function runCodemodDry( codemodName, filepath ) {
 	const binArgs = [
 		...config.jscodeshiftArgs,
-		...generateBinArgs(codemodName),
-		"--dry",
-		"--print",
-		"--silent",
+		...generateBinArgs( codemodName ),
+		'--dry',
+		'--print',
+		'--silent',
 		filepath,
 	];
-	const binPath = path.join(".", "node_modules", ".bin", "jscodeshift");
-
-	const result = child_process.spawnSync(binPath, binArgs, {
-		stdio: "pipe",
-	});
+	const result = child_process.spawnSync( jscodeshiftBin, binArgs, {
+		stdio: 'pipe',
+	} );
 
 	return result.stdout.toString();
 }

packages/calypso-codemods/config.js

@@ -29,37 +29,39 @@ const commonArgs = {
 const codemodArgs = {
 	'commonjs-exports': [
 		...commonArgs[ '5to6' ],
-		'--transform=node_modules/5to6-codemod/transforms/exports.js',
+		`--transform=${ require.resolve( '5to6-codemod/transforms/exports.js' ) }`,
 	],
 
 	'commonjs-imports': [
 		...commonArgs[ '5to6' ],
-		'--transform=node_modules/5to6-codemod/transforms/cjs.js',
+		`--transform=${ require.resolve( '5to6-codemod/transforms/cjs.js' ) }`,
 	],
 
 	'commonjs-imports-hoist': [
 		...commonArgs[ '5to6' ],
-		'--transform=node_modules/5to6-codemod/transforms/cjs.js',
+		`--transform=${ require.resolve( '5to6-codemod/transforms/cjs.js' ) }`,
 		'--hoist=true',
 	],
 
 	'named-exports-from-default': [
 		...commonArgs[ '5to6' ],
-		'--transform=node_modules/5to6-codemod/transforms/named-export-generation.js',
+		`--transform=${ require.resolve( '5to6-codemod/transforms/named-export-generation.js' ) }`,
 	],
 
 	'react-create-class': [
-		...commonArgs[ 'react' ],
-		'--transform=node_modules/react-codemod/transforms/class.js',
+		...commonArgs.react,
+		`--transform=${ require.resolve( 'react-codemod/transforms/class.js' ) }`,
 
 		// react-codemod options
 		'--pure-component=true',
 		'--mixin-module-name="react-pure-render/mixin"', // Your days are numbered, pure-render-mixin!
 	],
 
 	'react-proptypes': [
-		...commonArgs[ 'react' ],
-		'--transform=node_modules/react-codemod/transforms/React-PropTypes-to-prop-types.js',
+		...commonArgs.react,
+		`--transform=${ require.resolve(
+			'react-codemod/transforms/React-PropTypes-to-prop-types.js'
+		) }`,
 	],
 };
 

packages/calypso-codemods/index.js

@@ -1,40 +1,31 @@
 #!/usr/bin/env node
 
-/**
- * External dependencies
- */
-const fs = require('fs');
-const path = require('path');
-const child_process = require('child_process');
-const glob = require('glob');
-
 /**
  * Internal dependencies
  */
-const config = require('./config');
-const api = require('./api');
+const api = require( './api' );
 
 function main() {
-	const args = process.argv.slice(2);
-	if (args.length === 0 || args.length === 1) {
+	const args = process.argv.slice( 2 );
+	if ( args.length === 0 || args.length === 1 ) {
 		process.stdout.write(
 			[
 				'',
 				'calypso-codemods codemodName[,additionalCodemods…] target1 [additionalTargets…]',
 				'',
 				'Valid transformation names:',
-				api.getValidCodemodNames().join('\n'),
+				api.getValidCodemodNames().join( '\n' ),
 				'',
 				'Example: "calypso-codemods commonjs-imports client/blocks client/devdocs"',
 				'',
-			].join('\n')
+			].join( '\n' )
 		);
 
-		process.exit(0);
+		process.exit( 0 ); // eslint-disable-line no-process-exit
 	}
 
-	const [names, ...targets] = args;
-	names.split(',').forEach(codemodName => api.runCodemod(codemodName, targets));
+	const [ names, ...targets ] = args;
+	names.split( ',' ).forEach( codemodName => api.runCodemod( codemodName, targets ) );
 }
 
 main();

packages/calypso-codemods/jest.config.js

@@ -0,0 +1,6 @@
+module.exports = {
+	preset: '@automattic/calypso-build',
+	rootDir: __dirname,
+	testMatch: [ '<rootDir>/tests/*/codemod.spec.js' ],
+	setupFiles: [ '<rootDir>/setup-tests.js' ],
+};