Skip to content

Commit

Permalink
Drop react-a11y rules (#15)
Browse files Browse the repository at this point in the history
Consumers can use upstream's `plugin:jsx-a11y/recommended` ruleset instead.
  • Loading branch information
ockham authored and sirreal committed Dec 11, 2018
1 parent c8fa80d commit e0417e7
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 53 deletions.
4 changes: 4 additions & 0 deletions packages/eslint-config-wpcalypso/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
#### v2.0.0 (2018-01-24)

- Breaking: Removed the `react-a11y` ruleset. Consumers can use upstream's `plugin:jsx-a11y/recommended` ruleset instead.

#### v1.2.0 (2017-11-03)

- Added: [`no-duplicate-imports`](https://eslint.org/docs/rules/no-duplicate-imports) as error
Expand Down
12 changes: 0 additions & 12 deletions packages/eslint-config-wpcalypso/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,18 +29,6 @@ Or, if your project uses React and you want to opt in to additional React-specif
"extends": "wpcalypso/react"
```

Another set of rules available is the `react-a11y` set, which contains the base rules, the react rules, and a set of accessibility checks. To use these:

```
"extends": "wpcalypso/react-a11y"
```

For these accessibility rules, you will need to also install [the jsx-a11y plugin](https://github.com/evcohen/eslint-plugin-jsx-a11y):

```
npm install --save-dev eslint-plugin-jsx-a11y
```

Refer to the [ESLint documentation on Shareable Configs](http://eslint.org/docs/developer-guide/shareable-configs) for more information.

## Suggesting Changes
Expand Down
2 changes: 1 addition & 1 deletion packages/eslint-config-wpcalypso/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 2 additions & 3 deletions packages/eslint-config-wpcalypso/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "eslint-config-wpcalypso",
"version": "1.2.0",
"version": "2.0.0",
"description": "ESLint configuration following WordPress.com's Calypso JavaScript Coding Guidelines",
"keywords": [
"eslint"
Expand All @@ -15,8 +15,7 @@
],
"files": [
"index.js",
"react/index.js",
"react-a11y/index.js"
"react/index.js"
],
"license": "GPL-2.0+",
"repository": {
Expand Down
37 changes: 0 additions & 37 deletions packages/eslint-config-wpcalypso/react-a11y/index.js

This file was deleted.

0 comments on commit e0417e7

Please sign in to comment.