Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the react-modal module out of the build chunk #27509

Open
jsnajdr opened this issue Sep 30, 2018 · 2 comments
Open

Move the react-modal module out of the build chunk #27509

jsnajdr opened this issue Sep 30, 2018 · 2 comments

Comments

@jsnajdr
Copy link
Member

jsnajdr commented Sep 30, 2018

Looking at the output of npm analyze-bundles reveals that the react-modal module is bundled inside the vendors~build chunk. Is it really needed on the initial load? Probably not. Find where the react-modal module is synchronously required and modify these modals to be async-loaded at the time when they need to be displayed.

Learning objectives: understand the module dependency graph and how to move code out of the initial load path by async loading it.

@jsnajdr jsnajdr added this to Available Issues in GM 2018 Calypso Advanced Class Sep 30, 2018
@noisysocks noisysocks self-assigned this Oct 1, 2018
@noisysocks noisysocks moved this from Available Issues to Assigned, in progress in GM 2018 Calypso Advanced Class Oct 1, 2018
@noisysocks noisysocks removed their assignment Nov 26, 2018
@github-actions
Copy link

This issue is stale because it has been 180 days with no activity. You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation and apply one of relevant issue close labels.

@github-actions
Copy link

This issue is stale because it has been 180 days with no activity. You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation and apply one of relevant issue close labels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
GM 2018 Calypso Advanced Class
  
Assigned, in progress
Development

No branches or pull requests

2 participants