Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domains: it's possible to add different types of DNS records with the same label #2920

Closed
klimeryk opened this issue Jan 29, 2016 · 6 comments
Labels
[Feature Group] Emails & Domains Features related to email integrations and domain management. [Type] Bug

Comments

@klimeryk
Copy link
Contributor

As reported by @umurkontaci in #2262 (comment), it's possible to add different types of DNS records (say an A and CNAME records) pointing to the same label (test.example.com).

@klimeryk klimeryk added [Type] Bug [Feature Group] Emails & Domains Features related to email integrations and domain management. labels Jan 29, 2016
@designsimply
Copy link
Contributor

Tested and confirmed with the following steps to reproduce:

  1. Go to Domains > %domainname% > Name Servers and DNS
  2. Click the Add New DNS Record button
  3. Enter an A record with the subdomain "test"
  4. Enter a CNAME record with the subdomain "test"

Result: I was able to set A record and CNAME recording to the same point. I shouldn't be able to do that.

screen shot 2016-05-05 at thu may 5 6 27 15 pm
Seen at https://wordpress.com/domains/manage/threedotonefour.com/dns/design5279.wordpress.com using Chrome 50.0.2661.94 on Mac OS X 10.11.4

Also noting that this issue is 97 days old with no activity. @klimeryk, can this issue be moved to a milestone where it will be reviewed in a reasonable time? If not, I recommend closing it as wontfix.

@klimeryk
Copy link
Contributor Author

klimeryk commented May 8, 2016

We don't have a milestone for such issues, but this is also being tracked on our Trello board and it will surely be fixed (sooner or later :/). Would assigning it to a milestone (something like Cobalt: Backlog) help you during bug scrubs and such to filter out issues that really deserve some love?

@umurkontaci
Copy link
Contributor

I would rather not close these types of issues; they are not exactly a priority today, but I want to fix them when we can focus on the DNS editor.

@umurkontaci
Copy link
Contributor

For the record, I think we should only prevent a record to coexist with a CNAME record under the same name.

We can't have CNAME and A records at the same name, but we can certainly have A, AAAA, MX, TXT records under the same name and it wouldn't be a problem.

@klimeryk klimeryk modified the milestone: Cobalt: Backlog Jul 13, 2017
@apeatling apeatling modified the milestones: Product Quality, Product Quality: Setting up My Site Flows Jan 31, 2018
@rachelmcr
Copy link
Member

I tested and confirmed that this issue is still valid, using the steps @designsimply provided above.

@klimeryk
Copy link
Contributor Author

klimeryk commented Feb 2, 2021

This has been fixed on the backend when we added additional validation to make sure the new DNS zone would remain valid.

Screenshot 2021-02-02 at 11 17 39

It's not the prettiest, but it's quite robust and comprehensive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature Group] Emails & Domains Features related to email integrations and domain management. [Type] Bug
Projects
None yet
Development

No branches or pull requests

6 participants