-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jetpack Search: Display new plans #39858
Comments
@jsnmoon It actually does show single products on a separate block: Seems to come from here:
So it might be simple(r) to plug Search in, even though it would require some tweaks; e.g.:
|
@keoshi didn't expect you to be awake 😆 Thanks for the lead! I'll mess around with the code in that area. |
It looks like implementing the interface for
@DavidRothstein, is my assumption here correct? |
To check for UX/copy completeness : the steps in the flow leading from the jetpack.com/pricing page (tested being logged in):
Intercepting this connection flow from /pricing may not be a goal as JPS has its dedicate landing page at jetpack.com/upgrade/search/ and own remote install redirect, but since it involves plans page in the process, flagging it here. /cc @keoshi |
@jsnmoon If you have a Jetpack Search subscription on your site, I think Trying to test it now, though, I wasn't actually able to add a Jetpack Search subscription to a site in the first place, either in Calypso or via the backend admin... in Calypso the shopping cart just seems to get emptied when you add it to the cart, and in the backend admin you get an error about it not being available for a Jetpack site. There may be something wrong with the way the product is set up. But once that is fixed and it is possible to add the subscription, I expect it to be returned from the purchases endpoint automatically. |
Ah, I see that's actually one of the tasks already listed at the top of this issue :)
Not entirely sure why it doesn't work automatically when you replace |
I think this is all out of date, so closing |
All of this should get hidden behind a feature flag initially i guess.
There are a number of places the new plans need to get displayed:
I started some of the work on this in #39857
I suspect we should break this up into smaller issues. Maybe after creating a bunch of constants.
The text was updated successfully, but these errors were encountered: