Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetpack Search: Display new plans #39858

Closed
3 of 5 tasks
gibrown opened this issue Mar 4, 2020 · 8 comments
Closed
3 of 5 tasks

Jetpack Search: Display new plans #39858

gibrown opened this issue Mar 4, 2020 · 8 comments
Labels
[Feature] Search Jetpack Search - A feature to speed up and improve the look of Search on your site. [Type] Task

Comments

@gibrown
Copy link
Member

gibrown commented Mar 4, 2020

All of this should get hidden behind a feature flag initially i guess.

There are a number of places the new plans need to get displayed:

I started some of the work on this in #39857

I suspect we should break this up into smaller issues. Maybe after creating a bunch of constants.

@gibrown gibrown added [Type] New feature [Feature] Search Jetpack Search - A feature to speed up and improve the look of Search on your site. labels Mar 4, 2020
@jsnmoon
Copy link
Member

jsnmoon commented Mar 17, 2020

https://wordpress.com/plans/my-plan/example.com currently doesn't display any information about Jetpack Single Products. Do we intend to add something here? @gibrown @keoshi

Screen Shot 2020-03-17 at 3 01 06 PM

@keoshi
Copy link
Contributor

keoshi commented Mar 17, 2020

@jsnmoon It actually does show single products on a separate block:

image

Seems to come from here:

So it might be simple(r) to plug Search in, even though it would require some tweaks; e.g.:

@jsnmoon
Copy link
Member

jsnmoon commented Mar 17, 2020

@keoshi didn't expect you to be awake 😆

Thanks for the lead! I'll mess around with the code in that area.

@jsnmoon
Copy link
Member

jsnmoon commented Mar 18, 2020

wordpress.com/plans/my-plan/gibrown.wpsandbox.me::main

It looks like implementing the interface for /plans/my-plan/ will have to wait until we can query the Search product purchases:

<QuerySitePurchases siteId={ selectedSiteId } />

@DavidRothstein, is my assumption here correct?

@AnnaMag
Copy link
Contributor

AnnaMag commented Mar 18, 2020

To check for UX/copy completeness :

the steps in the flow leading from the jetpack.com/pricing page (tested being logged in):

  • selecting a paid plan (non-Pro)
  • filling in the remote install url input form
  • JPC recognizes pre-selected plan and skims through the plans grid landing at /checkout with the annual purchase option. Side Q: there is no alternative path should users change their minds or want to explore monthly (but close the page)
    The JPS Solution is available in the /plans tab afterwards, but not presented anywhere in the above flow.

Intercepting this connection flow from /pricing may not be a goal as JPS has its dedicate landing page at jetpack.com/upgrade/search/ and own remote install redirect, but since it involves plans page in the process, flagging it here.

/cc @keoshi

@DavidRothstein
Copy link
Contributor

@jsnmoon If you have a Jetpack Search subscription on your site, I think QuerySitePurchases would already return it. That endpoint just returns all the subscriptions for a site, so it should include Jetpack Search.

Trying to test it now, though, I wasn't actually able to add a Jetpack Search subscription to a site in the first place, either in Calypso or via the backend admin... in Calypso the shopping cart just seems to get emptied when you add it to the cart, and in the backend admin you get an error about it not being available for a Jetpack site. There may be something wrong with the way the product is set up. But once that is fixed and it is possible to add the subscription, I expect it to be returned from the purchases endpoint automatically.

@DavidRothstein
Copy link
Contributor

DavidRothstein commented Mar 19, 2020

Trying to test it now, though, I wasn't actually able to add a Jetpack Search subscription to a site in the first place, either in Calypso

Ah, I see that's actually one of the tasks already listed at the top of this issue :)

checkout page needs to work ala https://wordpress.com/checkout/gibrown.wpsandbox.me::test0/jetpack_backup_realtime

Not entirely sure why it doesn't work automatically when you replace jetpack_backup_realtime with jetpack_search, but like I said above it is probably just some small missing thing in the product setup.

@gibrown
Copy link
Member Author

gibrown commented Mar 29, 2020

I think this is all out of date, so closing

@gibrown gibrown closed this as completed Mar 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Search Jetpack Search - A feature to speed up and improve the look of Search on your site. [Type] Task
Projects
None yet
Development

No branches or pull requests

7 participants