Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetpack Search: Display in plans page #39942

Merged
merged 2 commits into from
Mar 17, 2020
Merged

Conversation

jsnmoon
Copy link
Member

@jsnmoon jsnmoon commented Mar 7, 2020

Partially addressees #39858. Design is not final and will be iterated upon.

Changes proposed in this Pull Request

  • Add support for showing Jetpack Search product in /plans via a feature gate.

Testing instructions

  1. Spin up this branch locally.

  2. Navigate to /plans and select a Jetpack site without any plan subscriptions. You should see something like this at the bottom:

Screen Shot 2020-03-09 at 4 30 33 PM

  1. Navigate to /plans and select a Jetpack site with a plan that includes Jetpack Backups. You should see something like this:

Screen Shot 2020-03-09 at 4 30 00 PM

  1. Navigate to /plans in wp-calypso for a Jetpack site without any Jetpack plans. Alternatively, you can add a flags=-jetpack/search-product query string to the URL. You should see something like this:

Screen Shot 2020-03-09 at 4 35 22 PM

  1. Repeat step 4 for a Jetpack site with a Jetpack plan that includes Backups. It should look like this:

 Screen Shot 2020-03-09 at 4 34 11 PM

@jsnmoon jsnmoon added [Status] In Progress [Feature] Search Jetpack Search - A feature to speed up and improve the look of Search on your site. labels Mar 7, 2020
@jsnmoon jsnmoon self-assigned this Mar 7, 2020
@matticbot
Copy link
Contributor

@matticbot
Copy link
Contributor

matticbot commented Mar 7, 2020

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~741 bytes added 📈 [gzipped])

name                   parsed_size           gzip_size
entry-main                 +1015 B  (+0.1%)     +184 B  (+0.0%)
entry-login                +1015 B  (+0.1%)     +201 B  (+0.1%)
entry-jetpack-cloud        +1015 B  (+0.1%)     +179 B  (+0.0%)
entry-domains-landing      +1015 B  (+0.2%)     +177 B  (+0.1%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~152 bytes added 📈 [gzipped])

name             parsed_size           gzip_size
plans                 +339 B  (+0.1%)      +76 B  (+0.1%)
jetpack-connect       +339 B  (+0.1%)      +76 B  (+0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~152 bytes added 📈 [gzipped])

name                           parsed_size           gzip_size
async-load-signup-steps-plans       +339 B  (+0.2%)      +75 B  (+0.2%)
async-load-design-blocks            +333 B  (+0.0%)      +77 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@jsnmoon jsnmoon force-pushed the add/jetpack-search-plans-part-1 branch from 7c25a67 to 015fb9b Compare March 9, 2020 22:45
@jsnmoon jsnmoon added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Type] New feature and removed [Status] In Progress labels Mar 9, 2020
@jsnmoon jsnmoon marked this pull request as ready for review March 9, 2020 22:46
@jsnmoon jsnmoon requested review from tyxla, keoshi, gibrown, enejb and a team March 9, 2020 22:49
@jsnmoon jsnmoon changed the title Jetpack Search: Display plans Jetpack Search: Display in plans page Mar 9, 2020
Copy link
Member

@gibrown gibrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than not needing the trial stuff.

client/lib/products-values/constants.js Outdated Show resolved Hide resolved
@tyxla
Copy link
Member

tyxla commented Mar 17, 2020

I'm going to review this one too soon, but in the meantime, I think @Automattic/jetpack-voyager should also take a look at it as they've been working on it recently.

@tyxla tyxla requested a review from a team March 17, 2020 10:13
@keoshi keoshi added the [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR label Mar 17, 2020
Copy link
Contributor

@keoshi keoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works exactly as expected! 🙌

@jsnmoon jsnmoon dismissed gibrown’s stale review March 17, 2020 16:17

Trial constants have been removed

@jsnmoon jsnmoon requested a review from gibrown March 17, 2020 16:17
Copy link
Member

@gibrown gibrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and still working.

@keoshi keoshi removed the [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR label Mar 17, 2020
@jsnmoon jsnmoon added the [Feature] Plans & Upgrades All of the plans on WordPress.com and flow for upgrading plans. label Mar 17, 2020
Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks great! I've left a minor comment, nothing blocking.

Ready to 🚢 !

client/blocks/product-selector/index.jsx Show resolved Hide resolved
@tyxla tyxla added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Mar 17, 2020
@tyxla
Copy link
Member

tyxla commented Mar 17, 2020

I re-ran the ICFY job because it was failing the first time.

@jsnmoon jsnmoon merged commit a2dbc28 into master Mar 17, 2020
@jsnmoon jsnmoon deleted the add/jetpack-search-plans-part-1 branch March 17, 2020 19:57
@jsnmoon
Copy link
Member Author

jsnmoon commented Mar 17, 2020

Thanks for the review, @tyxla! I'll be sure to tag @Automattic/jetpack-voyager in our future work on this going forward.

@a8ci18n
Copy link

a8ci18n commented May 22, 2020

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/3012953

Thank you @jsnmoon for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented May 27, 2020

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Plans & Upgrades All of the plans on WordPress.com and flow for upgrading plans. [Feature] Search Jetpack Search - A feature to speed up and improve the look of Search on your site. Jetpack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants