-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jetpack Search: Display in plans page #39942
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~741 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~152 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~152 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
7c25a67
to
015fb9b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than not needing the trial stuff.
I'm going to review this one too soon, but in the meantime, I think @Automattic/jetpack-voyager should also take a look at it as they've been working on it recently. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works exactly as expected! 🙌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and still working.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks great! I've left a minor comment, nothing blocking.
Ready to 🚢 !
I re-ran the ICFY job because it was failing the first time. |
Thanks for the review, @tyxla! I'll be sure to tag @Automattic/jetpack-voyager in our future work on this going forward. |
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/3012953 Thank you @jsnmoon for including a screenshot in the description! This is really helpful for our translators. |
Translation for this Pull Request has now been finished. |
Partially addressees #39858. Design is not final and will be iterated upon.
Changes proposed in this Pull Request
/plans
via a feature gate.Testing instructions
Spin up this branch locally.
Navigate to
/plans
and select a Jetpack site without any plan subscriptions. You should see something like this at the bottom:/plans
and select a Jetpack site with a plan that includes Jetpack Backups. You should see something like this:/plans
in wp-calypso for a Jetpack site without any Jetpack plans. Alternatively, you can add aflags=-jetpack/search-product
query string to the URL. You should see something like this: