Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stats: Insights: mix of sentence and title case in cards #40622

Closed
rickybanister opened this issue Mar 31, 2020 · 3 comments
Closed

Stats: Insights: mix of sentence and title case in cards #40622

rickybanister opened this issue Mar 31, 2020 · 3 comments
Assignees
@jancavan
Labels
Good First Issue Small, contained issues. [Type] Janitorial

Comments

@rickybanister
Copy link

I spotted a mix of sentence and title case in the card headings here:

image

Let's unify.
@gwwar
Copy link
Contributor

gwwar commented Apr 6, 2020

Note that sentence case is i18n dependant, so we should prefer updating string translations over any JS solutions.

@gwwar gwwar added the Good First Issue Small, contained issues. label Apr 6, 2020
@jancavan jancavan self-assigned this Apr 28, 2020
@jancavan jancavan mentioned this issue Apr 29, 2020
Merged
18 tasks
@mmtr
Copy link
Member

mmtr commented May 7, 2020

@jancavan has this been fixed in #41647?

@jancavan
Copy link
Contributor

jancavan commented May 7, 2020

Yes, fixed in: #41647. I'll close this.

@jancavan jancavan closed this as completed May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jancavan jancavan

Labels
Good First Issue Small, contained issues. [Type] Janitorial
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@rickybanister @danhauk @mmtr @gwwar @jancavan