Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(?P) InlineHelp: Fix help search visual issues #43753

Closed
retrofox opened this issue Jun 29, 2020 · 2 comments · Fixed by #43758
Closed

(?P) InlineHelp: Fix help search visual issues #43753

retrofox opened this issue Jun 29, 2020 · 2 comments · Fixed by #43758
Assignees
@retrofox
Labels
[Type] Enhancement

Comments

@retrofox
Copy link
Contributor

There are some visual issues to fix. Let's tackle them as part of this enhancement process.

  • it changes its height while requesting
  • the horizontal line gets narrow when searching

help-search-visual-issues
@retrofox retrofox self-assigned this Jun 29, 2020
@retrofox retrofox mentioned this issue Jun 29, 2020
Closed
@retrofox retrofox changed the title InlineHelp: Fix help search visual issues (?P) InlineHelp: Fix help search visual issues Jun 29, 2020
@retrofox retrofox mentioned this issue Jun 29, 2020
Merged
@obenland
Copy link
Member

I also noticed on iOS it zooms into the textfield once you tap'd into it. Maybe worth looking into, as well.

@cpapazoglou
Copy link
Contributor

I also noticed on iOS it zooms into the textfield once you tap'd into it. Maybe worth looking into, as well.

Using font-size >= 16px will stop zooming in iOS. They consider anything < 16px in inputs bad for accessibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@retrofox retrofox

Labels
[Type] Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

InlineHelp: fix visual minor issues Automattic/wp-calypso
3 participants
@retrofox @obenland @cpapazoglou