InlineHelp: fix visual minor issues #43758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
|
@cpapazoglou added you to the @Automattic/ajax team. :-D |
retrofox
added
the
[Status] Needs Review
cpapazoglou
reviewed
Jun 30, 2020
client/my-sites/customer-home/cards/features/help-search/style.scss
Outdated
Show resolved
Hide resolved
cpapazoglou
requested changes
Jun 30, 2020
There was a problem hiding this comment.
@retrofox Thanks for working on this. It definitely seems better now.
Just address the minor aesthetics of the placeholder touching the container on the right while animating and we are good to go.
yes, thanks for your review, Harris. I've tackled it here 4ec6e9b501555a3a91960180a935abd976795616 |
retrofox
force-pushed
the
update/help-search-visual-issues
branch
from
4ec6e9b
to
cc8cfd2
Compare
retrofox
force-pushed
the
update/help-search-visual-issues
branch
from
cc8cfd2
to
fde4260
Compare
matticbot
removed
the
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
This PR tweak the
<HelpSearch />component which renders the support card, rightly rendered in the customer home page.Testing instructions
Confirm it fixes:
Fixes #43753