Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(3P) Add optional prop to implement a celebratory image to "Site Creation" checklist step #43938

Open
getdave opened this issue Jul 7, 2020 · 4 comments

Comments

@getdave
Copy link
Contributor

getdave commented Jul 7, 2020

Based on comment here let's add a celebratory image to the checklist step for "Site Created".

@danhauk can confirm design. Or possibly @jancavan?

Would it make sense to add an image to this step to bump up the celebratory nature little bit up?

@simison Quite possibly. Seems like a good suggestion. Currently, I'm working to this design by @danhauk. If we want/need to add this then it should probably be in a followup PR.

If @danhauk agrees then I'm happy to raise a separate Issue.

Originally posted by @getdave in #43861 (comment)

Update:
We can add an optional prop that can receive a component so the fireworks image (or whatever else) can be added here.

@jancavan
Copy link
Contributor

jancavan commented Jul 7, 2020

Yes, I agree that this one card could be a little bit more celebratory. We can add the illustration back like so:

Screen Shot 2020-07-08 at 9 01 49 AM

I feel like the dark gray pill is a little too close to the heading. I think we should move it down a bit? @getdave @danhauk

@danhauk
Copy link
Contributor

danhauk commented Jul 7, 2020

I agree. When this is picked up, could we make the task component have an optional image prop? I'm thinking of an additional use case would be as a video placeholder to open a support doc in a modal (something I was exploring previously as a future enhancement):

image

@jancavan
Copy link
Contributor

jancavan commented Jul 8, 2020

@getdave I updated the mockup above. I think the illustration can be made slightly bigger. Thanks.

@jeryj jeryj changed the title Add celebratory image to "Site Creation" checklist step Add image prop to implement a celebratory image to "Site Creation" checklist step Jul 30, 2020
@jeryj jeryj removed the [Status] Needs Design Add this to PRs that need input from Design label Jul 30, 2020
@jeryj jeryj changed the title Add image prop to implement a celebratory image to "Site Creation" checklist step Add optional prop to implement a celebratory image to "Site Creation" checklist step Jul 30, 2020
@jeryj jeryj changed the title Add optional prop to implement a celebratory image to "Site Creation" checklist step (3P) Add optional prop to implement a celebratory image to "Site Creation" checklist step Jul 30, 2020
@github-actions
Copy link

This issue is stale because it has been 180 days with no activity. You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation and apply one of relevant issue close labels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants