Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nav Unification: Rename the Ocean color scheme to Aquatic; update user preferences accordingly #47256

Closed
mreishus opened this issue Nov 9, 2020 · 2 comments
Assignees
Labels
[Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two. [Type] Task

Comments

@mreishus
Copy link
Contributor

mreishus commented Nov 9, 2020

Task

  • Rename the Ocean color scheme to Aquatic.
  • Develop a one-time script to move user preferences from ocean -> aquatic.
  • Right after this is pushed, run the one-time script.

Context: We want to introduce the wp-admin color scheme named ocean, and keep its same name in calypso. To do that, we'll have to move the existing ocean 'out of the way'. For more context, see the issues below.

Project: Nav Unification Color Schemes

Reference Issues

@mreishus mreishus added the [Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two. label Nov 9, 2020
@marekhrabe marekhrabe self-assigned this Nov 10, 2020
@marekhrabe
Copy link
Contributor

marekhrabe commented Nov 10, 2020

My launch plan for this migration explained below. It has a few differences from the original description so each of those steps works on their own and removes any time pressure of aligning the databse migration and scheme renaming in Calypso.

Phase One

Make the current calypso ocean colors respond to both names "ocean" and "aquatic" but hide the "ocean" from the list of available ones in the color scheme picker.

Deploy the above. Since both names have the same colors, there will be no visual regression. Hiding "ocean" means it won't get any new users and everyone picking the blue scheme will already use the new name "aquatic".

Status: Shipped in #47273

Phase Two

Write and execute one-off script that processes user options and migrates "ocean" users to "aquatic". Again, no visual regression but we no longer have anyone using "ocean" in the database. Everybody has "aquatic" set.

Status: in progress D52536-code

Phase Three

After migration done, "ocean" scheme in calypso isn't used by anybody and we can safely:

  • update its SCSS file with colors from wp-admin ocean
  • update the SVG preview image with new colors
  • resurface the scheme in the picker UI
  • deploy

Status: TODO, will happen as part of #47036.

Final result

All users who were using "Ocean" will see they have "Aquatic" selected. There will be a new color scheme called Ocean with completely new colors, aligned to the wp-admin counterpart.

@mreishus
Copy link
Contributor Author

Finished all steps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two. [Type] Task
Projects
None yet
Development

No branches or pull requests

3 participants