Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color Schemes: Add Aquatic and hide Ocean #47273

Merged
merged 1 commit into from
Nov 10, 2020

Conversation

marekhrabe
Copy link
Contributor

@marekhrabe marekhrabe commented Nov 10, 2020

This is a phase one of #47256 (comment). Please refer to the plan to understand the scope of this PR.

Changes proposed in this Pull Request

  • add aquatic color scheme (uses exact same colors as ocean)
  • add temporary code in the color scheme picker to pretend "ocean" is "aquatic"

I know what's the usual reaction when people see temporary code. I'll personally make sure it will be followed upon :)

Testing instructions

  • set your account to use Ocean (either on local master branch or in prod https://wordpress.com/me/account)
  • boot this PR
  • confirm you can still see dark blue colors of "ocean" in the local UI
  • navigate to /me/account on this branch and confirm the UI shows "aquatic" as the active scheme

Phase one of #47256

Reference Issues

@marekhrabe marekhrabe added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. Color Schemes labels Nov 10, 2020
@marekhrabe marekhrabe self-assigned this Nov 10, 2020
@matticbot
Copy link
Contributor

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~52 bytes added 📈 [gzipped])

name     parsed_size           gzip_size
account       +221 B  (+0.1%)      +52 B  (+0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~125 bytes added 📈 [gzipped])

name                      parsed_size           gzip_size
async-load-design-blocks       +221 B  (+0.0%)      +67 B  (+0.0%)
async-load-design              +221 B  (+0.0%)      +58 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@frontdevde frontdevde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested as per testing instructions and can confirm:

  • Ocean and Aquatic themes look identical
  • When having selected Ocean in production this change will show Aquatic as selected and show the expected colors.

I know what's the usual reaction when people see temporary code. I'll personally make sure it will be followed upon :)

Sounds good! With that, LGTM 👍

@marekhrabe marekhrabe merged commit e678dde into master Nov 10, 2020
@marekhrabe marekhrabe deleted the update/color-schemes-ocean-aquatic branch November 10, 2020 14:57
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 10, 2020
@a8ci18n
Copy link

a8ci18n commented Nov 10, 2020

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/5157902

Thank you @marekhrabe for including a screenshot in the description! This is really helpful for our translators.

@mreishus mreishus mentioned this pull request Nov 10, 2020
94 tasks
@a8ci18n
Copy link

a8ci18n commented Nov 19, 2020

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants