-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Press This doesn't pull the post URL, only the title #51899
Comments
Follow-up with any updates #4084045-zen |
Thanks @silvio-meter , @donalirl for highlighting this issue. I tested and see the same issue on both AT and simple site. |
FWIW, I also ended up doing some testing on an Atomic site for a user where the button does not work at all for them, and I noticed if I highlight some text before clicking on the Press This button, the highlighted text along with the url is inserted as a quote block. So in this regard, it seems to work as described in the instructions shown in Settings > Writing, ie |
@nickpagz Yeah, I agreed with you. I think the original design is that you need to highlight the text before clicking on the Press This button as the description said. Maybe we should update the description to ensure people understand that they have to highlight the text before clicking Press This button. Or we should assume the user wants to highlight all of the pages without highlighting everything. @silvio-meter How do you think? |
@arthur791004 I think an update to the messaging would be better. Tbh, clicking the Press This button without first highlighting text as a way to copy the entire page content is poor form, IMO, and akin to copying content, even if there's a referral link (which the user may be able to remove before publishing anyways?). Just my 2 cents. |
@nickpagz Yeah, I agreed! Do you have any idea about the new copy? |
Is another option to just include the URL of the page as the fallback? It wouldn't be copying the entire content of the page - but it would at least form a post with a Title and Link to the reference page? |
@jordesign I think it's great! We just need to let the user know that the default content will be the URL if they don't highlight any text. |
The important step that is often overlooked is to highlight some text before clicking on Press This. From the documentation:
Source: Using Press This If the bookmarklet javascript is amended to check selection text, to pull in title when selection is blank, this will work Excerpt:
|
So my thoughts here are 'why don't we do both'? Can we
The wording in the support doc is pretty good:
Compared to the instructions in Settings > Writing:
I feel like the instructions in the settings could be extended a little more to explain:
We could also include a link to the full support doc there. What do you think @kristastevens ? |
I think one way is to show an alert to tell our users to select the text. But we cannot show i18n in this case. So I still prefer to notice our users by improving the wording. Also, we can use URL as a default link/reference if our users don't select any of them.
Maybe we can step-based approach to guide our users on how to use it? For example, Here are a few steps to clip text, images and videos from any web page
|
In looking into this I tested Press This by highlighting some copy and clicking the bookmarklet. A new post modal appeared with the copy, the post title and a clickable URL back to the original post. 👍 Here's the original copy explaining Press This in Settings > Writing:
Here's some proposed copy that includes an explanation of what it does and (hopefully clearer!) steps on how to use it. Let me know what you think! Press This allows you to copy text, images, and video from any web page and add them to a new post on your site, along with an automatic citation. How to use Press This
|
That copy looks brilliant to me - thanks Krista |
Looks good to me too 👍 |
@jordesign Do we still need to handle this part? |
Hey @arthur791004 - I'd love to have that happen as a fallback - but I don't imagine it is vital. If we've got higher priority things - then I think updating the wording would be sufficient. |
@jordesign @kristastevens I've created a PR to improve this one and here are the results Press This DescriptionSituation where no text is selectedpress-this-demo.mov |
Hi @arthur791004, looks good to me, except for a typo I made. Please change "favourites" to "favorites" in the first bullet point. (A British spelling variant crept in. Sorry about that!) |
@kristastevens Okay, thank you! |
@jordesign @kristastevens This change is shipped! |
Steps to reproduce the behavior
What I expected to happen
This should open up the Editor inside a pop-up with the post/page URL added inside the post body.
What actually happened
Only the post title is pulled, not the URL itself.
Screenshot:
The text was updated successfully, but these errors were encountered: