-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update wording of Press This #56570
Update wording of Press This #56570
Conversation
Link to Calypso live: https://calypso.live?image=registry.a8c.com/calypso/app:build-16366 |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~86 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
@@ -26,23 +26,28 @@ class PressThis extends Component { | |||
|
|||
return ( | |||
<div className="press-this"> | |||
<Card className="site-settings"> | |||
<Card className="press-this__card site-settings"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix CSS namespace guideline according to eslint
} | ||
|
||
if ( ! encodeURIComponent( sel ) ) { | ||
sel = doc.title; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use title as the content of quote to improve the handling of situations where no text is selected where no text is selected. This script will be used in bookmarks, so we cannot add comment.
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/6671573 Thank you @arthur791004 for including a screenshot in the description! This is really helpful for our translators. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I'd missed all the cool discussion going on in #51899
My only thought was whether we should be doing something like '{{li}}item 1{{/li}}
for the bullet point list, just in case different langauges have a different ways of writing lists out. But I think since each item is a complete sentence on it's own it's probably fine to just break each bullet into its own string.
Tested this, and I really like this feature!
Translation for this Pull Request has now been finished. |
f7dd0f9
to
aa5b72a
Compare
Changes proposed in this Pull Request
press-this-demo.mov
Testing instructions
Related to #51899