Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wording of Press This #56570

Merged
merged 3 commits into from
Oct 7, 2021
Merged

Update wording of Press This #56570

merged 3 commits into from
Oct 7, 2021

Conversation

arthur791004
Copy link
Contributor

@arthur791004 arthur791004 commented Sep 27, 2021

Changes proposed in this Pull Request

image

press-this-demo.mov

Testing instructions

  • Go to Settings > General > Writing
  • Check the wording is correct or not

Related to #51899

@github-actions
Copy link

github-actions bot commented Sep 27, 2021

@matticbot
Copy link
Contributor

matticbot commented Sep 27, 2021

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~86 bytes added 📈 [gzipped])

name              parsed_size           gzip_size
settings-writing       +310 B  (+0.1%)      +86 B  (+0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@@ -26,23 +26,28 @@ class PressThis extends Component {

return (
<div className="press-this">
<Card className="site-settings">
<Card className="press-this__card site-settings">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix CSS namespace guideline according to eslint

}

if ( ! encodeURIComponent( sel ) ) {
sel = doc.title;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use title as the content of quote to improve the handling of situations where no text is selected where no text is selected. This script will be used in bookmarks, so we cannot add comment.

@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 28, 2021
@arthur791004 arthur791004 requested a review from a team September 28, 2021 04:41
@arthur791004 arthur791004 added the [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging label Sep 28, 2021
@a8ci18n
Copy link

a8ci18n commented Sep 28, 2021

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/6671573

Thank you @arthur791004 for including a screenshot in the description! This is really helpful for our translators.

Copy link
Member

@p-jackson p-jackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I'd missed all the cool discussion going on in #51899

My only thought was whether we should be doing something like '{{li}}item 1{{/li}} for the bullet point list, just in case different langauges have a different ways of writing lists out. But I think since each item is a complete sentence on it's own it's probably fine to just break each bullet into its own string.

Tested this, and I really like this feature!

@a8ci18n
Copy link

a8ci18n commented Oct 6, 2021

Translation for this Pull Request has now been finished.

@arthur791004 arthur791004 merged commit c123a06 into trunk Oct 7, 2021
@arthur791004 arthur791004 deleted the update/press-this-wording branch October 7, 2021 03:33
@github-actions github-actions bot removed [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants