Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paragraph Block: Selecting Color from Toolbar doesn't change text color in editor #54990

Open
ccwalburn opened this issue Jul 28, 2021 · 32 comments · Fixed by Automattic/themes#4756
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature Group] Appearance & Themes Features related to the appearance of sites. [Feature] Post/Page Editor The editor for editing posts and pages. NMIT Bug KitKat's NMIT Bugs flag [Pri] Normal [Product] WordPress.com All features accessible on and related to WordPress.com. Triaged To be used when issues have been triaged. [Type] Bug User Report This issue was created following a WordPress customer report

Comments

@ccwalburn
Copy link

ccwalburn commented Jul 28, 2021

2023-10-04 update - this issue has been remained open as themes are fixed on a theme-by-theme basis. The only remaining theme that this is currently waiting on is Karuna. See latest comments


When you select some text in a Paragraph block and change the color using the Font Color option on the toolbar, it changes the color on the front end, but not in the editor.

Steps to reproduce the behavior

  1. Activate the Rebalance theme
  2. Create a new post and add a Paragraph block
  3. Add some text to the Paragraph block; highlight one word in the text and click the Text Color option under the down arrow on the toolbar:

![screenshot](+)
Image URL:

  1. Select a color
  2. Publish the page.

What I expected to happen

I expected to see the font color in the Paragraph block change in the editor.

What actually happened

The font color was added to the Paragraph Block toolbar, but it didn't change the font color in the editor:

![screenshot](+)
Image URL:

However, the font color did change on the front end:

![screenshot](+)
Image URL:

Context

Browser / OS version

I was using Chrome on Mac version 10.15.7

Is this specific to the applied theme? Which one?

I've been able to reproduce it on Rebalance and Dara. I tried testing on Dalston, Twenty Twenty, and Ryu but couldn't reproduce there. It seems like it may not happen on Recommended themes.

Does this happen on simple or atomic sites or both?

I only tested on Simple Sites

Is there any console output or error text?

Level of impact (Does it block purchases? Does it affect more than just one site?)

I have only had one report, but I can reproduce it on my test site.

4173857-zen

Reproducibility (Consistent, Intermittent) Leave empty for consistent.

Screenshot / Video: If applicable, add screenshots to help explain your problem.

@ccwalburn ccwalburn added [Type] Bug User Report This issue was created following a WordPress customer report labels Jul 28, 2021
@ccwalburn ccwalburn added this to Needs triage in HE Triaging Board (new bugs) via automation Jul 28, 2021
@inaikem
Copy link
Contributor

inaikem commented Aug 2, 2021

Thanks for raising this issue! I am able to replicate on my test sites.

Wondering if this and When Headings Font Size Set in Customizer, Type Scale is Ignored on Blog Posts Block Post Titles (#54911) are somehow related?

@alshakero
Copy link
Member

alshakero commented Aug 3, 2021

Can confirm reproducing this. It's reproducible in Rebalance theme, but not all themes. We'll investigate the issue today.

alshakero added a commit to Automattic/themes that referenced this issue Aug 3, 2021
This is an attempt to fix Automattic/wp-calypso#54990. 

Please note that we added the file as-is, without much consideration to the rest of CSS and the clashes that might occur. 

This PR is intended to show a quick way to fix the issue.
@alshakero
Copy link
Member

PR ready here Automattic/themes#4359

@kwight kwight moved this from Triaged to Prioritized in HE Triaging Board (new bugs) Aug 4, 2021
@tellisbethel
Copy link

tellisbethel commented Aug 24, 2021

I believe I've encountered a version of this bug here: 4233694-zen
The only difference is that when selecting the text colour, the text changes to the wrong colour in the editor (instead of not changing at all), but then reflects the correct colour when previewing or on the live site.

@goblinartificer
Copy link

An interesting rendition in 4257432-zen today: the colors look right until you try to apply any other text decoration, then only the bold/underline/etc shows up. The preview is right, but the editor is wrong.

@hacchism
Copy link

Another instance in 4293838-zen with Canard theme.

@thekingsprojects
Copy link

thekingsprojects commented Sep 21, 2021

Also seeing this in the Aquene theme: 14276663-hc and replicated on my own test site. Not sure if we're doing anything about that given that's a retired theme now, but worth noting, I suppose.

@sbathompson-he
Copy link

Experienced this bug on the Affinity theme here: 30538090-hc

@tellisbethel
Copy link

Preview colour is right but colour in editor when using the palette (not the picker) is wrong: 30511716-hc
Simple site.

@alshakero
Copy link
Member

Hi @scruffian! I have sent a PR to fix this issue earlier. It's probably a bad PR but will give you a clear idea about this issue. Can you please give it look? Thanks!

@EjayhanFernandes
Copy link

This occurred as well here 4320518-zen.
Theme: Gateway by Rescue Themes.

@ahmadbaig1
Copy link

User returned and requested a quicker resolution 31830828-hc.

@inaikem
Copy link
Contributor

inaikem commented Sep 29, 2021

@Robertght, do you think this is something for Flow Patrol could look into?

@inaikem inaikem added the [Feature] Post/Page Editor The editor for editing posts and pages. label Sep 29, 2021
@Robertght
Copy link

Thanks! I've added it now. cc @Automattic/flow-patrol-create

@benchilcote
Copy link

Adding another report - 22972062-hc

Theme isola. Simple site.

@ccwalburn
Copy link
Author

Another report - 4335926-zen
Theme: Lovecraft

@dcoleonline
Copy link
Contributor

Reported in 31927285-hc
Theme: Baskerville 2
We should follow up in 4337424-zen

Example:
image

@nicolynramos
Copy link

Another report for Lovecraft, simple site - 31984931-hc

@scruffian scruffian reopened this Oct 4, 2021
HE Triaging Board (new bugs) automation moved this from Closed to Needs triage Oct 4, 2021
@kosiew
Copy link

kosiew commented Oct 6, 2021

Hi @nicolynramos ,

Thanks for reporting this

I could reproduce this on a Simple site and Atomic site on the Lovecraft theme.

@kosiew kosiew moved this from Needs triage to Triaged in HE Triaging Board (new bugs) Oct 6, 2021
@kosiew
Copy link

kosiew commented Oct 6, 2021

I also tested that the on Rebalance, the Paragraph block text color does change.

@scruffian
Copy link
Member

I believe this will be fixed by WordPress/gutenberg#35514. It might take some time for that commit to make it to simple/atomic sites....

@mzitinfo
Copy link

We just had another case of this in 4368273-hc, with the Independent Publisher theme.

@KokkieH
Copy link
Contributor

KokkieH commented Oct 16, 2021

The Text Color option appears to be completely missing from the toolbar drop-down:
New_Post_‹kokkiestrialtestsite—_WordPress_com

There's also now a Highlight option which isn't present in the screen shot at the top of this issue, which makes me wonder if #57036 might be somehow related.

Missing Text Color option pointed out by user in https://wordpress.com/forums/topic/no-colors/

@KokkieH
Copy link
Contributor

KokkieH commented Oct 16, 2021

It appears this is intentional. See #57054.

@DjamWork
Copy link

Maybe another case here zd-4379749
user wants to change the link color.

@Nic-Sevic
Copy link
Contributor

Another instance here: 27931525-hc

Also +1 to labelling this as text highlight being confusing. I would expect highlight to change just the background color, not the text itself

@as-esu
Copy link

as-esu commented Jan 4, 2022

4657930-zen
I could reproduce the issue using the Karuna theme, but only if I choose the suggested colours.
Picking custom colour, reflected changes in the editor.

@francoishvz
Copy link

Another instance here: 35792663-hc

Workaround was to pick a custom color.

@cometgrrl cometgrrl added the [Feature Group] Appearance & Themes Features related to the appearance of sites. label Aug 2, 2022
@cometgrrl
Copy link
Contributor

I could reproduce the issue using the Karuna theme, but only if I choose the suggested colours.
Picking custom colour, reflected changes in the editor.

Same for me (although white is suggested and displayed correctly in the editor, none of the others worked).

@github-actions
Copy link

github-actions bot commented Aug 2, 2022

Support References

This comment is automatically generated. Please do not edit it.

  • 4173857-zen
  • 4233694-zen
  • 4257432-zen
  • 4293838-zen
  • 4320518-zen
  • 4335926-zen
  • 4337424-zen
  • 4657930-zen

@cometgrrl
Copy link
Contributor

@jeffikus Can you take a look at this? It seems there's at least one more theme (Karuna) that's affected by this bug.

@cuemarie cuemarie removed this from Prioritized - Bugs in HE Triaging Board (new bugs) Oct 4, 2023
@cuemarie cuemarie added [Product] WordPress.com All features accessible on and related to WordPress.com. [Pri] Normal Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". labels Oct 4, 2023
@cuemarie
Copy link

cuemarie commented Oct 4, 2023

📌 ACTIONS

  • Due to the age of this issue, I've downgraded the priority from High to Normal to better reflect it's status in the larger context of open bugs in the repo.
  • Looks like this is getting fixed at the theme level, which is why it's still open - waiting on a fix for Karuna:
Screen.Capture.on.2023-10-04.at.16-31-14.mov

CC: @Automattic/theam

@cuemarie cuemarie added the NMIT Bug KitKat's NMIT Bugs flag label Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature Group] Appearance & Themes Features related to the appearance of sites. [Feature] Post/Page Editor The editor for editing posts and pages. NMIT Bug KitKat's NMIT Bugs flag [Pri] Normal [Product] WordPress.com All features accessible on and related to WordPress.com. Triaged To be used when issues have been triaged. [Type] Bug User Report This issue was created following a WordPress customer report
Projects