Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twenty Sixteen: Custom color setting for Buttons Block in widgets doesn't work #4915

Closed
hacchism opened this issue Oct 18, 2021 · 2 comments
Closed

Comments

@hacchism
Copy link

Quick summary

Buttons Block doesn't respect custom color settings(text and background) at all when the block is in widgets.

Steps to reproduce

  1. Activate "Twenty Sixteen"
  2. Go to https://example.wordpress.com/wp-admin/widgets.php and add a Buttons Block into Sidebar
  3. Set a custom text/background color by selecting one from some recommended colors(The issue can't be replicated when hitting "Custom color" link and choosing one outside of the recommendations)

What you expected to happen

The text/background color you selected should be reflected.

What actually happened

The button shows up with white text(#fff) and black background(#32373c).

Screen Shot on 2021-10-18 at 14:42:36

Context

The issue is similar to #4782 and #4580 actually. However, they are for Follow Blog button specifically whereas this is for Buttons Block.

Operating System

No response

Browser

No response

Simple, Atomic or both?

No response

Theme-specific issue?

No response

Other notes

No response

Reproducibility

Consistent

Severity

Some (< 50%)

Available workarounds?

Yes, difficult to implement

Workaround details

We can use the following CSS to force the buttons in the widget area to have custom text/background color. But it's limited to Premium plan or higher.

.widget-area .wp-block-button__link {
    color: #fff;
    background-color: #007acc;
}
@jordesign
Copy link
Contributor

Scrubbed and confirmed. It looks like the classes are being included in the HTML - but there are no styles applied to the buttons in that area.

<a class="wp-block-button__link has-white-color has-bright-red-background-color has-text-color has-background">Button 1</a>

Shifting over to the themes repo

@jordesign jordesign transferred this issue from Automattic/wp-calypso Oct 27, 2021
@jordesign
Copy link
Contributor

Closing in favour of #4580 where things are being tracked together

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants