Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footer Credit: Paragraph Block tied to Footer Credit should be locked #81611

Closed
hacchism opened this issue Sep 12, 2023 · 3 comments
Closed

Footer Credit: Paragraph Block tied to Footer Credit should be locked #81611

hacchism opened this issue Sep 12, 2023 · 3 comments
Labels
[Feature] Full Site Editor The site editor. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. [Pri] Low [Product] WordPress.com All features accessible on and related to WordPress.com. Triaged To be used when issues have been triaged. [Type] Feature Request Feature requests

Comments

@hacchism
Copy link

Quick summary

With FSE theme, you can edit the Paragraph Block tied to Footer Credit. However, the change never gets reflected to a live site. This confuses users.

We should lock the Paragraph Block so it's clear that the block shouldn't be edited. And ideally, we can show a prompt to head to Customize > Site Identity > Footer Credit to change the footer credit option.

Steps to reproduce

  1. Create a simple site.
  2. Switch to any FSE theme (i.e. Livro that I tested with)
  3. Go to Appearance → Editor → Patterns → Footer
  4. Find the existing Paragraph Block that is tied to Footer Credit and add any text into it and save the change

Screen Shot on 2023-09-12 at 09:05:05

What you expected to happen

A normal user would expect the change to be reflected on their live site.

What actually happened

No change. Only the Footer Credit selected in Customize > Site Identity > Footer Credit shows up.

Screen Shot on 2023-09-12 at 09:05:58

Impact

Some (< 50%)

Available workarounds?

Yes, easy to implement

Platform (Simple and/or Atomic)

No response

Logs or notes

No response

@hacchism hacchism added [Type] Bug Needs triage Ticket needs to be triaged [Feature] Full Site Editor The site editor. [Product] WordPress.com All features accessible on and related to WordPress.com. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. labels Sep 12, 2023
@cuemarie cuemarie added [Type] Feature Request Feature requests and removed [Type] Bug labels Sep 12, 2023
@cuemarie
Copy link

📌 REPRODUCTION RESULTS

  • Tested on Simple – Replicated

📌 FINDINGS/SCREENSHOTS/VIDEO
AFAIK, it's by design that the footer credit set in the customizer overrides the block one, but this definitely results in a confusing experience for users who have full ability to edit the footer credit in the Site Editor.

QpMeWK.mp4

📌 ACTIONS

  • We've never had the Footer credit block locked from edits, since the Customizer overrides it, so I've changed this to a Feature Request type instead.
  • Feature Request kept

@cuemarie cuemarie added Triaged To be used when issues have been triaged. footer credits and removed Needs triage Ticket needs to be triaged footer credits labels Sep 12, 2023
@cuemarie
Copy link

Did a little further research into the Footer Credit on Templates - looks like there was work being put into a better solution that was ultimately put on hold, here: https://github.com/Automattic/view-design/issues/244

@mmtr
Copy link
Member

mmtr commented Jul 24, 2024

This shouldn't be needed as of D156044-code (Simple sites) and Automattic/jetpack#38458 (Atomic sites).

@mmtr mmtr closed this as completed Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Full Site Editor The site editor. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. [Pri] Low [Product] WordPress.com All features accessible on and related to WordPress.com. Triaged To be used when issues have been triaged. [Type] Feature Request Feature requests
Development

No branches or pull requests

3 participants