Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSE Beta: Footer credit looks different in the editor vs front-end of the site #59363

Closed
creativecoder opened this issue Dec 17, 2021 · 15 comments
Assignees
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Full Site Editor The site editor. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. [Goal] Full Site Editing [Pri] Low [Product] WordPress.com All features accessible on and related to WordPress.com. Triaged To be used when issues have been triaged. [Type] Bug

Comments

@creativecoder
Copy link
Contributor

creativecoder commented Dec 17, 2021

Quick summary

When using a theme that support block templates, the Footer credit looks different in the Site editor vs the front end of the site.

Editor Front-end
Screen Shot 2021-12-17 at 13 40 36 Screen Shot 2021-12-17 at 13 42 51

Steps to reproduce

  1. Create an FSE beta site at horizon.wordpress.com/new
  2. Compare what you see in the Site editor vs what's on the front-end of the site in the footer

What you expected to happen

They look the same.

What actually happened

They don't (see screenshots, above)

Context

No response

Browser

No response

Simple/Atomic

No response

Other notes

No response

Reproducibility

Consistent

Severity

No response

Available workarounds?

No response

Workaround details

No response

@creativecoder
Copy link
Contributor Author

Note that this is currently caused by how we inject the WordPress.com footer credit for FSE sites. We need to represent this visually in the editor, rather than only through filters on the server-side.

@carinapilar
Copy link

Just noticed this when doing some FSE training. It's especially confusing because it's a regular Paragraph block on the editor, not something like a "Footer Credit" block as it happens with other FSE blocks.

@cuemarie
Copy link

cuemarie commented Jan 24, 2022

I've also encountered this in testing FSE sites. On both Simple and AT test sites, the WordPress.com Footer Credit reflects the selection under Appearance > Customize > Site Identity, and does not reflect what is shown or edited in the Site Editor > Footer Template Part.

Annotation on 2022-01-24 at 14-15-39

Annotation on 2022-01-24 at 14-16-12

@the-misha
Copy link

Also ran into this, as documented here.

@cuemarie
Copy link

I think this may be resolved - or at least in some cases.

Just had a user on Premium plan with theme Byrne who wanted to update their footer credit; and I see that the template no longer contains a Paragraph block with the credit, and instead their Appearance > Customize area is able to properly impact the footer credit.

Not sure if this is resolved on all themes or some, so leaving open for now, but wanted to share that update.

@Greatdane
Copy link

I can still see it. Perhaps there is a better way we can visualize the footer credit? As @carinapilar said, something like a Footer Credit Block that represents what is in the customizer.

@Greatdane Greatdane added the Triaged To be used when issues have been triaged. label Feb 24, 2022
@jordesign jordesign removed the Needs triage Ticket needs to be triaged label Mar 10, 2022
@arinoch
Copy link

arinoch commented May 16, 2022

Had this issue with a user while fixing something else in 35495388-hc. Was able to reproduce it on multiple themes--including Twenty Twenty-Two, so not strictly an A8C themes problem, in my own testing. User expected their FSE footer changes to take over when we hid the WordPress.com footer credit. They did not. This seems the most relevant issue due to this comment.

Followed up in 5217168-zd-woothemes.

Further testing (thank you, @happychait!) in p1652659261220859-slack-C03TY6J1A suggests a possible workaround.

  1. Create a new template, for example a front page template.

  2. Assign that new template to at least one page.

  3. Add your footer and other necessary parts to that template.

  4. Your custom FSE footer now shows up as intended.

@helenaartmann
Copy link

Another case here: 5358224-zn

@kuropixel
Copy link

Another case. 36319808-hc

@github-actions
Copy link

github-actions bot commented Aug 4, 2022

Support References

This comment is automatically generated. Please do not edit it.

  • 5217168-zen
  • 5862586-zen

@zdenys
Copy link
Contributor

zdenys commented Jan 13, 2023

It was a major TIL for me in 5862586-zd-woothemes

On the site with FSE theme Tsubaki, user's custom footer edited via Site Editor was not showing up on the frontend until I actually checked the HTML of the very paragraph block they added to find out that it contained <a href="https://wordpress.org" rel="nofollow">. As soon as I changed href value to a different one (user's own site URL), the custom footer credit started showing up on the front end.

@cuemarie
Copy link

Note: Did a little research into the Footer Credit on Templates today - it looks like there was work being put into a better solution that was ultimately put on hold, here: https://github.com/Automattic/view-design/issues/244

For now it seems this is not high on the priority list anywhere.

📌 ACTIONS

  • lowering priority for now

@cuemarie cuemarie added [Pri] Low [Feature] Full Site Editor The site editor. [Product] WordPress.com All features accessible on and related to WordPress.com. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. and removed [Pri] Normal labels Sep 12, 2023
@github-actions github-actions bot added the Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". label Sep 12, 2023
@mrfoxtalbot
Copy link

This issue has a lot of overlap with #81611

Do you think we could close this in favor of the other one, @creativecoder?

@creativecoder
Copy link
Contributor Author

Do you think we could close this in favor of the other one, @creativecoder?

Fine with me!

@mmtr
Copy link
Member

mmtr commented Jul 24, 2024

This should have been fixed by D156044-code (Simple sites) and Automattic/jetpack#38458 (Atomic sites).

@mmtr mmtr closed this as completed Jul 24, 2024
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Full Site Editor The site editor. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. [Goal] Full Site Editing [Pri] Low [Product] WordPress.com All features accessible on and related to WordPress.com. Triaged To be used when issues have been triaged. [Type] Bug
Projects
Development

No branches or pull requests