-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FSE Beta: Footer credit looks different in the editor vs front-end of the site #59363
Comments
Note that this is currently caused by how we inject the WordPress.com footer credit for FSE sites. We need to represent this visually in the editor, rather than only through filters on the server-side. |
Just noticed this when doing some FSE training. It's especially confusing because it's a regular Paragraph block on the editor, not something like a "Footer Credit" block as it happens with other FSE blocks. |
Also ran into this, as documented here. |
I think this may be resolved - or at least in some cases. Just had a user on Premium plan with theme Byrne who wanted to update their footer credit; and I see that the template no longer contains a Paragraph block with the credit, and instead their Appearance > Customize area is able to properly impact the footer credit. Not sure if this is resolved on all themes or some, so leaving open for now, but wanted to share that update. |
I can still see it. Perhaps there is a better way we can visualize the footer credit? As @carinapilar said, something like a |
Had this issue with a user while fixing something else in 35495388-hc. Was able to reproduce it on multiple themes--including Twenty Twenty-Two, so not strictly an A8C themes problem, in my own testing. User expected their FSE footer changes to take over when we hid the WordPress.com footer credit. They did not. This seems the most relevant issue due to this comment. Followed up in 5217168-zd-woothemes. Further testing (thank you, @happychait!) in p1652659261220859-slack-C03TY6J1A suggests a possible workaround.
|
Another case here: 5358224-zn |
Another case. 36319808-hc |
Support References This comment is automatically generated. Please do not edit it.
|
It was a major TIL for me in 5862586-zd-woothemes On the site with FSE theme Tsubaki, user's custom footer edited via Site Editor was not showing up on the frontend until I actually checked the HTML of the very paragraph block they added to find out that it contained |
Note: Did a little research into the Footer Credit on Templates today - it looks like there was work being put into a better solution that was ultimately put on hold, here: https://github.com/Automattic/view-design/issues/244 For now it seems this is not high on the priority list anywhere. 📌 ACTIONS
|
This issue has a lot of overlap with #81611 Do you think we could close this in favor of the other one, @creativecoder? |
Fine with me! |
This should have been fixed by D156044-code (Simple sites) and Automattic/jetpack#38458 (Atomic sites). |
Quick summary
When using a theme that support block templates, the Footer credit looks different in the Site editor vs the front end of the site.
Steps to reproduce
What you expected to happen
They look the same.
What actually happened
They don't (see screenshots, above)
Context
No response
Browser
No response
Simple/Atomic
No response
Other notes
No response
Reproducibility
Consistent
Severity
No response
Available workarounds?
No response
Workaround details
No response
The text was updated successfully, but these errors were encountered: