Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing media on Simple Sites after the files.wordpress.com > wp-content/uploads path change #87642

Closed
pauljacobson opened this issue Feb 20, 2024 · 114 comments · Fixed by #90895
Closed
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature Group] Content Management Features related to the tools and screens that admins use to manage their sites core content. [Feature] Media The media screen in Calypso, general media management, or integration with third party media. [Interaction #] > 50 (Automated) interaction count label for better visibility. Please don't add these manualliy. [Platform] Simple [Pri] High [Product] WordPress.com All features accessible on and related to WordPress.com. [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts Triaged To be used when issues have been triaged. [Type] Bug

Comments

@pauljacobson
Copy link

pauljacobson commented Feb 20, 2024

UPDATE May 9, 2024: Read before Reporting

Please investigate the missing image issue you're dealing with before reporting on this thread.

Current escalation thread: p1715271974999929/1715265147.089629-slack-C02FMH4G8

(Possible) Current Symptoms

  • Images can't be seen on Calypso, wp-admin and live site
  • Primary domain is set to external name servers, or has only been recently pointed to WP.com (so still propagating)
  • Sometimes we can repro, sometimes we can't
  • Privacy settings on the site might be set to Coming Soon/Private





Previous Symptoms:

This is exclusive to the issue triggered by the change of the file paths on Simple Sites from files.wordpress.com to /wp-content/uploads/.

  • Images load for users on the media library and the editor, but not on the frontend
  • Images load for HEs correctly while proxied
  • User report discrepancies between the file paths they can see X what they can't see (files.wordpress.com X /wp-content/uploads/)

Updates

  • Initial escalation thread: p1708425842573889-slack-C02FMH4G8
  • An initial fix was issued around Feb 20
  • A second fix for .blog subdomains was issued around March 20.
  • New escalation thread: p1711639735891989-slack-C02FMH4G8

Quick summary

I noticed that there are a number of reports of missing images or other media on a number of WordPress.com sites. The sites seem not to be plugin-enabled sites. Opening this issue to track reports.

My first encounter of this issue was in 7766785-zen where the user reported that all media save for the most recent two posts are no longer loading, and the relevant media is not displaying in the Media library.

Steps to reproduce

According to @vinnykaur , we haven't been able to reproduce this on our side. See p1708426096835589-slack-C02FMH4G8

What you expected to happen

Media should load consistently.

What actually happened

Media seems to be removed or is not loading for older content.

Impact

Some (< 50%)

Available workarounds?

No and the platform is unusable

Platform (Simple and/or Atomic)

Simple

Logs or notes

Other reports:

@pauljacobson pauljacobson added [Type] Bug [Feature] Media The media screen in Calypso, general media management, or integration with third party media. Needs triage Ticket needs to be triaged [Product] WordPress.com All features accessible on and related to WordPress.com. [Feature Group] Content Management Features related to the tools and screens that admins use to manage their sites core content. labels Feb 20, 2024
@github-actions github-actions bot added the [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts label Feb 20, 2024
@vinnykaur
Copy link

Just to add, users reported missing images from media or errors while uploading images or "this image has an empty alt attribute" message in their media.

Copy link

github-actions bot commented Feb 20, 2024

Support References

This comment is automatically generated. Please do not edit it.

@github-actions github-actions bot added the Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". label Feb 20, 2024
@pauljacobson
Copy link
Author

Here is another report: 7766858-zen

Hello, I have a problem since today, when I create a post and upload a picture for this post, I can't see any pictures? Even the images in the media are not displayed! Wordpress also does not show if an image has been uploaded or not when uploading, images are not displayed either.

@rinazrina
Copy link

I got a report that seems related: 7765648-zd-a8c

I'm unable to place images into the text. It says,"This image has an empty alt attribute;"and then gives the file name. This just began out of the blue

Simple site. Theme: Adventure Journal.
The user tried using Firefox and Chrome. Same issue.

I can't reproduce the issue when SU.

@AminMehrani
Copy link

AminMehrani commented Feb 20, 2024

7767112-zen
7765578-zen
7764793-zen
7764843-zen
7766266-zen
7766855-zen

@kkalam7757
Copy link

kkalam7757 commented Feb 20, 2024

7765226-zen
7783758 -Zen: The user experiences issues with the classic editor when using Chrome but not when using Firefox.
7958329 -zen
8180596 -zen

@Neha93517
Copy link

Image issues:
7764756-zen
7764441-zen

Video not loading issue: (could be related)
7765382-zen
7764757-zen: The user reported this to be resolved after troubleshooting. I have requested information on which step worked for the user.

@github-actions github-actions bot added the [Interaction #] > 10 (Automated) interaction count label for better visibility. Please don't add these manualliy. label Feb 20, 2024
@AnjanaV93
Copy link

AnjanaV93 commented Feb 20, 2024

7765525-zen
7765153-zen
7765260-zen
7765731-zen
7764334-zen

@cselamor
Copy link

7765479-zen

@dev-sabbir
Copy link

7766596-zd-a8c

@rw-ye
Copy link

rw-ye commented Feb 20, 2024

Another report: 7765844-zd-a8c

At the time of the chat, I had the user try a different network connection and the media library started working again.

@liviopv
Copy link

liviopv commented Feb 20, 2024

7767212-zd-a8c

Couldn't reproduce while proxied and unproxied on Chrome. User's browser info https://www.whatsmybrowser.org/b/5F39M

User cannot reproduce it while using mobile data.

@pauljacobson
Copy link
Author

7766817-zen seems similar to 7766785-zen where the user also mentioned empty alt attributes:

Yesterday and this morning, I was unable to post a picture on my wordpress blog. Instead of the picture, the message "this image has an empty alt attribute" appears. When I attempt to add images from my wordpress images folder, I have the same problem.

WordPress Starter plan and using the retired MistyLook theme.

@ariel-maidana
Copy link

7767210-zen
Reported originally on Chrome.
User replicated partially on Edge.
I couldn't reproduce the issue while proxied on Chrome and while unproxied on Firefox.

@github-actions github-actions bot added [Interaction #] > 20 (Automated) interaction count label for better visibility. Please don't add these manualliy. and removed [Interaction #] > 10 (Automated) interaction count label for better visibility. Please don't add these manualliy. labels Feb 20, 2024
@dev-sabbir
Copy link

dev-sabbir commented Feb 20, 2024

7767223-zd-a8c
7767297-zd-a8c

@pauljacobson
Copy link
Author

7766774-zen

I am trying to upload an image in a post, but the editor gives me the message "the image has an empty ALT attribute" and the image is not displayed.

Site is on a WordPress.com Explorer plan

@sajjadsaeed
Copy link

sajjadsaeed commented Feb 20, 2024

7766141-zen (Explorer plan)
7764604-zen (Stater plan)

@sajjadsaeed
Copy link

sajjadsaeed commented Feb 20, 2024

7764527-zen

@galakhyati
Copy link

Another instance here: 8227732-zd-a8c
Site is on Starter plan with domain correctly pointing to WordPress.com NS. The site's privacy is set to Private.

@nazilya06
Copy link

8228750-zd-a8c

Set the site from Public to Coming Soon. I switched the primary address for a while, and the images started appearing.

@galakhyati
Copy link

Another report where:

  • The domain is pointing well to WordPress.com NS,
  • The site's privacy is set to Private.
  • Site is on WordPress.com Explorer plan
    Ticket: 8230161-zd-a8c

devicenull added a commit that referenced this issue May 24, 2024
In order to solve #87642, we need to proxy any images in the media area via the public API.

This solves two main cases:
1) Where the primary redirect is not yet pointed to us via DNS
2) Where a service like Cloudflare is in front of the primary redirect, and blocks "hotlinking" images

These cases both used to work fine, as media was served from *.files.wordpress.com regardless of the actual
domain being used.  Once this was been moved to use wp-content/uploads (in order to fix issues when third
party cookies are blocked), the two cases above (and probably some others we don't know about) stopped working.
@dev-sabbir
Copy link

@pauljacobson, there is a workaround (I am not super sure if we can call it a workaround).

Images appear if we set the site's privacy to Coming Soon mode.

devicenull added a commit that referenced this issue May 24, 2024
… site. (#90895)

* Proxy content via public-api, even when we're on a simple site.

In order to solve #87642, we need to proxy any images in the media area via the public API.

This solves two main cases:
1) Where the primary redirect is not yet pointed to us via DNS
2) Where a service like Cloudflare is in front of the primary redirect, and blocks "hotlinking" images

These cases both used to work fine, as media was served from *.files.wordpress.com regardless of the actual
domain being used.  Once this was been moved to use wp-content/uploads (in order to fix issues when third
party cookies are blocked), the two cases above (and probably some others we don't know about) stopped working.
@devicenull
Copy link
Contributor

not done yet, thanks github :)

@devicenull devicenull reopened this May 24, 2024
@supernovia
Copy link
Contributor

  • Primary domain points here
  • Site is private
  • Simple site
  • Just the Calypso media library is broken
  • I can repro

8233739-zd-a8c

@devicenull
Copy link
Contributor

This is resolved for users, but will not currently work in support sessions (fixing for that is in progress)

@devicenull
Copy link
Contributor

The fix ended up causing #91136 and was reverted

@rosepajaroja
Copy link

zen-8221056

Workaround: Change the site's privacy settings to public, then back again to private. (similar to the workaround shared by @ dev-sabbir above).

@mrfoxtalbot
Copy link

Thank you for the update, @devicenull. I have modified the priority to reflect this.

@devicenull
Copy link
Contributor

The fix has been deployed (again), and as far as I can tell is working properly.

@mrfoxtalbot
Copy link

This seems to be fixed in my testing simple sites (with and without a custom domain).

@ClassicRKR27
Copy link

Hey, team - regarding 8303289-zd-a8c it looks like the issue is still not resolved (I tested on both Chrome and Firefox and could replicate the issue), and the user is getting quite upset. Is there anything we can tell them at this time?

@ahmadbaig1
Copy link

@ClassicRKR27 The issue with 8303289-zd-a8c looks to be a different issue. The post is missing images due to Google links being used, which are broken. The media library and other posts look fine.

@dev-sabbir
Copy link

Simple site, privacy is set to private. Images can be visible in classic WP Admin dashboard.

8308379-zd-a8c

@liviopv
Copy link

liviopv commented Jun 10, 2024

@devicenull can you take a look at this recent report above?

@devicenull
Copy link
Contributor

@devicenull can you take a look at this recent report above?

Are you sure that's actually the issue the user is reporting? Their message doesn't make it super clear to me. There are still issues viewing the media library via support sessions w/ private blogs.

@liviopv
Copy link

liviopv commented Jun 13, 2024

@devicenull you're right, sorry for the confusion! I simulated a login using a different method and I can't reproduce.

Considering the last two reports are unrelated, is it ok to close this?

@devicenull
Copy link
Contributor

Yes, let's consider this resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature Group] Content Management Features related to the tools and screens that admins use to manage their sites core content. [Feature] Media The media screen in Calypso, general media management, or integration with third party media. [Interaction #] > 50 (Automated) interaction count label for better visibility. Please don't add these manualliy. [Platform] Simple [Pri] High [Product] WordPress.com All features accessible on and related to WordPress.com. [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts Triaged To be used when issues have been triaged. [Type] Bug
Development

Successfully merging a pull request may close this issue.