Setup guided flow redirects #91094

heavyweight · 2024-05-24T08:58:51Z

Related to 7365-gh-Automattic/dotcom-forge

Proposed Changes

The guided flow has a few cases where we want to redirect the users to another flow.

If the user answers Migrating or importing an existing site we redirect to /setup/import-hosted-site
If the user answer Create newsletter we redirect to /setup/newsletter
If the user answers Sell something and Get a website built quickly we redirect to /start/do-it-for-me-store
If the user answers Get a website built quickly we redirect to /start/do-it-for-me

Why are these changes being made?

The SegmentationSurvey didn't offer a way to bypass the navigation to the next page. To avoid navigation issues after redirection I extended it to have skipNextNavigation which is called with the question key and answers. This will easily allow us to customize how the navigation happens and avoid issues with history.

Testing Instructions

Visit /start/guided
Verify that selecting Migrating or importing an existing site will redirect to /setup/import-hosted-site
Verify that selecting Create newsletter will redirect to /setup/newsletter
Verify that by selecting Sell something and Get a website built quickly we redirect to /start/do-it-for-me-store
Verify that by selecting Get a website built quickly we redirect to /start/do-it-for-me

Pre-merge Checklist

Has the general commit checklist been followed? (PCYsg-hS-p2)
Have you written new tests for your changes?
Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
Have you checked for TypeScript, React or other console errors?
Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

github-actions · 2024-05-24T08:59:03Z

Calypso Live (direct link)

	https://calypso.live?image=registry.a8c.com/calypso/app:build-108948

Jetpack Cloud live (direct link)

	https://calypso.live?image=registry.a8c.com/calypso/app:build-108948&env=jetpack

Automattic for Agencies live (direct link)

	https://calypso.live?image=registry.a8c.com/calypso/app:build-108948&env=a8c-for-agencies

heavyweight · 2024-05-24T09:01:50Z

client/signup/steps/initial-intent/index.tsx

+		}
+
+		if ( _answerKeys.includes( 'client' ) ) {
+			// return `/setup/${ IMPORT_HOSTED_SITE_FLOW }`;


@escapemanuele for some reason I thought that we needed to redirect to a separate flow for agencies. Will delete it

No, only migration, difm and newsletter!

matticbot · 2024-05-24T09:09:05Z

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Async-loaded Components (~190 bytes added 📈 [gzipped])

name                                    parsed_size           gzip_size
async-load-signup-steps-initial-intent       +437 B  (+0.4%)     +190 B  (+0.6%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

…ond survey page

matticbot · 2024-05-24T19:39:07Z

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

odyssey-stats

To test WordPress.com changes, run install-plugin.sh $pluginSlug setup/guided-flow-redirects on your sandbox.

agrullon95 · 2024-05-24T20:01:20Z

client/components/segmentation-survey/hooks/use-segmentation-survey-navigation.ts

@@ -79,6 +81,11 @@ const useSegmentationSurveyNavigation = ( {
 		recordContinueEvent( currentQuestion, answers );

 		await onContinue?.( currentQuestion );
+
+		if ( skipNextNavigation?.( currentQuestion.key, answers?.[ currentQuestion.key ] ) ) {


cc. @phcp incase you have any thoughts on these changes inside the segmentation survey.

Thanks for pinging, it looks good to me. 😄

agrullon95 · 2024-05-24T20:10:20Z

client/signup/steps/initial-intent/index.tsx

@@ -40,7 +41,38 @@ export default function InitialIntentStep( props: Props ) {
 		// eslint-disable-next-line react-hooks/exhaustive-deps
 	}, [] );

+	const getRedirectForAnswers = ( _answerKeys: string[] ): string => {
+		if ( _answerKeys.includes( 'migrate-or-import-site' ) ) {


The redirection changes are working well!

Adding a reminder that we need to handle the scenario when the user selects the Create a site for a client option for the first question. It does not need to be done in this PR.

Based on the segment for that option, the user should not be redirected to any of these custom flows. We have to add logic to skip the second goal question if the user selects Create a site for a client. (@wongasy - Correct me if this is inaccurate).

We have to add logic to skip the second goal question if the user selects Create a site for a client

Yes, we shouldn't show the second question in that case nor the user be redirected. We should go on and show the appropriate plans.

The only doubt I have is that in Figma https://www.figma.com/design/3u71fUJraClkRQiLrAORPf/Trail-Map-Project?node-id=3981-1577&m=dev there is Hosting Flow (Developers / Agencies). Is that something we don't need? @nuriapenya @wongasy

Also, https://github.com/Automattic/dotcom-forge/issues/7433, as Q1 is not skippable for now

Thanks @escapemanuele for reaching out for clarification!

The requirements have evolved and the design we have in Figma doesn't necessarily match up with what we landed on for the solution.

If users answered "Create a site for a client", they should not see question 2, but instead be taken to the plans page. We also need to add a link to A4A sign up in the plans page (which wasn't mentioned in the PT). Looks like we'll also need a design from @nuriapenya for that. Let's also ensure we gate the A4A link such that it only shows up for users in the developer segment.

Opened https://github.com/Automattic/dotcom-forge/issues/7434 to keep track of the A4A link.

Updated i2 designs in Figma and added more context on Slack: p1716831873951849/1716813332.564069-slack-C0347E545HR

phcp

Nice work! The PR looks good, I also tested on the Entrepreneur Trial flow and I haven't spotted any regression.

phcp · 2024-05-24T20:21:31Z

client/components/segmentation-survey/hooks/use-segmentation-survey-navigation.ts

@@ -79,6 +81,11 @@ const useSegmentationSurveyNavigation = ( {
 		recordContinueEvent( currentQuestion, answers );

 		await onContinue?.( currentQuestion );
+
+		if ( skipNextNavigation?.( currentQuestion.key, answers?.[ currentQuestion.key ] ) ) {


Thanks for pinging, it looks good to me. 😄

Setup guided flow redirects

59f44fb

heavyweight requested a review from escapemanuele May 24, 2024 09:00

matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 24, 2024

Merge branch 'trunk' into setup/guided-flow-redirects

0240317

heavyweight commented May 24, 2024

View reviewed changes

escapemanuele assigned heavyweight May 24, 2024

escapemanuele requested a review from a team May 24, 2024 09:18

heavyweight added 2 commits May 24, 2024 14:10

Minor cleanup

caee263

Fix avoid navigating to domains when navigation is skipped on the sec…

08826a7

…ond survey page

escapemanuele marked this pull request as ready for review May 24, 2024 14:27

heavyweight requested a review from phcp May 24, 2024 14:34

escapemanuele added the Guided Onboarding label May 24, 2024

agrullon95 self-requested a review May 24, 2024 14:52

Merge branch 'trunk' into setup/guided-flow-redirects

482c3d6

agrullon95 approved these changes May 24, 2024

View reviewed changes

phcp approved these changes May 24, 2024

View reviewed changes

phcp mentioned this pull request May 27, 2024

Segmentation Survey: Clear answers after the Trial Acknowledge step and minor fixes #91178

Merged

7 tasks

heavyweight merged commit 489ec8e into trunk May 28, 2024
11 checks passed

heavyweight deleted the setup/guided-flow-redirects branch May 28, 2024 08:55

github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 28, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Setup guided flow redirects #91094

Setup guided flow redirects #91094

heavyweight commented May 24, 2024 •

edited

Loading

github-actions bot commented May 24, 2024 •

edited by matticbot

Loading

heavyweight May 24, 2024

escapemanuele May 24, 2024

matticbot commented May 24, 2024 •

edited

Loading

matticbot commented May 24, 2024

agrullon95 May 24, 2024

phcp May 24, 2024

agrullon95 May 24, 2024

escapemanuele May 24, 2024

escapemanuele May 24, 2024

wongasy May 25, 2024

escapemanuele May 27, 2024

nuriapenya May 27, 2024

phcp left a comment

phcp May 24, 2024

Setup guided flow redirects #91094

Setup guided flow redirects #91094

Conversation

heavyweight commented May 24, 2024 • edited Loading

Proposed Changes

Why are these changes being made?

Testing Instructions

Pre-merge Checklist

github-actions bot commented May 24, 2024 • edited by matticbot Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

matticbot commented May 24, 2024 • edited Loading

matticbot commented May 24, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

phcp left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

heavyweight commented May 24, 2024 •

edited

Loading

github-actions bot commented May 24, 2024 •

edited by matticbot

Loading

matticbot commented May 24, 2024 •

edited

Loading