-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Square Payments: Create landing page #91993
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~4 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~9307 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, I have checked, and it matches the design for both logged-in and logged-out versions. I have also tested the CTA redirection and track event, thanks for adding it.
I have added a couple of minor (non-blocking) comments, but this can be
d358237
to
de02d87
Compare
de02d87
to
1eed13b
Compare
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/15101213 Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday. Thank you @WBerredo for including a screenshot in the description! This is really helpful for our translators. |
Translation for this Pull Request has now been finished. |
Related to https://github.com/Automattic/dotcom-forge/issues/7781
Related to https://github.com/Automattic/dotcom-forge/issues/7785
Proposed Changes
/start-with/square-payments
PS: Mobile visualization will be handled in a follow-up PR
Why are these changes being made?
As part of the Partner Aware Onboarding project to shows users a page to about the partnership before starting a store with those definitions selected.
Testing Instructions
/start-with/square-payments
in a logged in and logged out session/setup/entrepreneur/start?partnerBundle=square