Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Square Payments: Create landing page #91993

Merged
merged 5 commits into from
Jun 21, 2024
Merged

Conversation

WBerredo
Copy link
Collaborator

Related to https://github.com/Automattic/dotcom-forge/issues/7781
Related to https://github.com/Automattic/dotcom-forge/issues/7785

Proposed Changes

  • Create a landing page to be shown on the /start-with/square-payments
  • Update page layout to mach the design in figma
  • Add a CTA to redirect to the store creation endpoint
  • Send a track event for page view and CTA click

PS: Mobile visualization will be handled in a follow-up PR

Why are these changes being made?

As part of the Partner Aware Onboarding project to shows users a page to about the partnership before starting a store with those definitions selected.

Testing Instructions

  • Go to /start-with/square-payments in a logged in and logged out session
  • Check if the layout matches the pictures below
  • Click on the CTA and check if you are redirected to /setup/entrepreneur/start?partnerBundle=square
  • Check on tracks if the events are being properly recorded
Logged out Logged in
CleanShot 2024-06-20 at 11 00 34@2x CleanShot 2024-06-20 at 11 02 06@2x

@WBerredo WBerredo self-assigned this Jun 20, 2024
@matticbot
Copy link
Contributor

matticbot commented Jun 20, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~4 bytes added 📈 [gzipped])

name           parsed_size           gzip_size
entry-stepper        +86 B  (+0.0%)       +4 B  (+0.0%)
entry-main           +86 B  (+0.0%)       +4 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~9307 bytes added 📈 [gzipped])

name        parsed_size              gzip_size
start-with     +26876 B  (+2013.2%)    +9307 B  (+1491.5%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@epeicher epeicher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, I have checked, and it matches the design for both logged-in and logged-out versions. I have also tested the CTA redirection and track event, thanks for adding it.

I have added a couple of minor (non-blocking) comments, but this can be :shipit:

client/start-with/style.scss Show resolved Hide resolved
@WBerredo WBerredo force-pushed the add/square-payments-landing branch from d358237 to de02d87 Compare June 20, 2024 22:18
@WBerredo WBerredo force-pushed the add/square-payments-landing branch from de02d87 to 1eed13b Compare June 20, 2024 22:51
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/square-payments-landing on your sandbox.

@WBerredo WBerredo merged commit 3a11252 into trunk Jun 21, 2024
11 checks passed
@WBerredo WBerredo deleted the add/square-payments-landing branch June 21, 2024 11:33
@a8ci18n
Copy link

a8ci18n commented Jun 21, 2024

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/15101213

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @WBerredo for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Jun 25, 2024

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants