Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor: improve copy of Guided Tour for new insert menu #10131

Merged
merged 1 commit into from Dec 19, 2016
Merged

Editor: improve copy of Guided Tour for new insert menu #10131

merged 1 commit into from Dec 19, 2016

Conversation

mcsf
Copy link
Member

@mcsf mcsf commented Dec 16, 2016 •
edited by artpi

Improves upon #9699

Before

screen shot 2016-12-16 at 19 46 52

After

screen shot 2016-12-16 at 19 44 26

@mcsf mcsf added [Feature] Post/Page Editor The editor for editing posts and pages. Guided Tours [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR labels Dec 16, 2016
@mcsf mcsf self-assigned this Dec 16, 2016
@mcsf mcsf requested a review from Copons December 16, 2016 19:47
@matticbot
Copy link
Contributor

matticbot commented Dec 16, 2016 •
edited by folletto

Test live: https://calypso.live/posts?branch=update/editor-insert-menu-tour&tour=editorInsertMenu

Copons
Copons approved these changes Dec 16, 2016
View reviewed changes
Copy link
Contributor

@Copons Copons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!
LGTM but I'm not sure if I'm supposed to remove the design review tag.

@mcsf
Copy link
Member Author

mcsf commented Dec 18, 2016

supposed to remove the design review tag

Maybe one of @iamtakashi or @folletto could have a quick quick look and remove the tag? 💋

@folletto
Copy link
Contributor

I checked it in Chrome: it triggers too early (it triggered when the Editor was still loading, i.e. the pulsating dot in the masterbar) and it's slightly misplaced, but since this PR is just about the copy...

...the change is good, ship it :shipit:

@folletto folletto added [Status] Ready to Merge and removed [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR labels Dec 19, 2016
@mcsf
Copy link
Member Author

mcsf commented Dec 19, 2016

it triggers too early (it triggered when the Editor was still loading, i.e. the pulsating dot in the masterbar)

That's unexpected. The GT framework itself should hold off tours when a section is loading.

In any case, thanks for the review!

@mcsf mcsf merged commit f083fc5 into master Dec 19, 2016
@mcsf mcsf deleted the update/editor-insert-menu-tour branch December 19, 2016 10:33
@aduth aduth mentioned this pull request Jan 11, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Copons Copons Copons approved these changes

Assignees

@mcsf mcsf

Labels
[Feature] Post/Page Editor The editor for editing posts and pages. Guided Tours
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mcsf @matticbot @folletto @Copons