Site Settings: Mark fields as changed when changing in wrapSettingsForm #10690
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #10670, where it was reported by @drw158 that the Settings: Discussion form does not alert users when changing to another Settings tab with unsaved settings.
This appears to have been introduced in #9899, which reduxified the Discussion form.
The solution proposed in this PR is to mark each field as changed when handling a change in any of the fields.
To test:
/settings/discussion/$site
, where$site
is one of your sites./cc