New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
State: Add timezones
selectors functions
#10932
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was ab1d23d5e5096cb16f64bc74952f9fceb3e28282 supposed to be part of this PR? The action types seem unrelated to the selectors.
Is there a reason you have the selector tests separated out in a different PR? Are they dependent on something other than these selectors?
Yes, It's a mistake. I should remove this commit from this PR
The only one reason is that these tests use a fixture file which is located into the This commit 6814cff0d231fcab4233aa29c8bd9e1faa27013e adds the selectors tests: import { MANUAL_UTC_OFFSETS } from 'state/timezones/test/fixture'; I could create a transition commit if we consider necessary, though. |
f1218c7
to
2e3f479
Compare
2e3f479
to
1363327
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, no need to get fancy, looks good from my end!
Thanks @obenland for the review. Is it |
This patch adds three state selectors and it's the first step of a set of PRs which improve the current implement of Timezones regarding the data approach, component, etc.
Testing
Beyond the app should work ok, you would run the selectors tests:
NOTE: Selectors tests are already done (6814cff0d231fcab4233aa29c8bd9e1faa27013e), but they will be added
in another PRhere: #10941. The whole work related with the timezones improvements is here: #10788. You could take a look to see the trace of this process.