Theme: fix upload area visual styling and cursor #11214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
folletto
added
[Feature Group] Appearance & Themes
folletto
added
the
[Status] Needs Review
omarjackman
reviewed
Feb 7, 2017
| const dropText = translate( | ||
| 'Drop files or click here to upload' | ||
| ); | ||
| const uploadInstructionsText = translate( | ||
| "Only single .zip files are accepted." |
There was a problem hiding this comment.
This'll generate a warning and should be changed to single quotes
There was a problem hiding this comment.
facepalm you're right. I wonder why Atom didn't mark it :|
There was a problem hiding this comment.
This'll generate a warning and should be changed to single quotes
That sounded kinda blunt, sorry about that 😄
budzanowski
approved these changes
Feb 8, 2017
folletto
added
[Status] Ready to Merge
and removed
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the styling of the theme upload drop/click area, fixes #11037.
Before:
After (with hover):
To test
pointer.