Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Happychat: Persist transcripts between reloads #11662

Merged
merged 4 commits into from Mar 27, 2017

Conversation

jordwest
Copy link
Contributor

@jordwest jordwest commented Mar 1, 2017

This stores the last 30 messages between refreshes, showing the recent message history before the transcript arrives from the server. It will also persist between sessions, so the user can see the most recent messages from any previous session.

How to test

  1. Go to http://calyso.localhost:3000/me/chat
  2. Send > 30 messages
  3. Open the Redux devtools
  4. Refresh the page
  5. At first, the 30 most recent messages should be shown. Soon after, you should see the older messages appear in the timeline once they're fetched from the server. Ensure messages are in the correct order.
  6. Check the Redux state history to confirm. At bootup, there should have been 30 messages in the state. Once the HAPPYCHAT_TRANSCRIPT_RECEIVE action fired, the happychat.timeline should show the full transcript of the recent session.

@matticbot
Copy link
Contributor

@matticbot matticbot added the [Size] M Medium sized issue label Mar 1, 2017
@jordwest jordwest force-pushed the update/happychat/refactor-with-middleware-2 branch from d0b04b4 to 9561778 Compare March 7, 2017 05:04
@jordwest jordwest force-pushed the update/happychat/fetch-transcripts branch from def957b to 0cd121d Compare March 7, 2017 06:16
@matticbot matticbot added the [Size] M Medium sized issue label Mar 7, 2017
@jordwest jordwest added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] In Progress labels Mar 7, 2017
@jordwest jordwest force-pushed the update/happychat/refactor-with-middleware-2 branch from 9561778 to d6b3850 Compare March 8, 2017 06:07
@matticbot
Copy link
Contributor

@jordwest This PR needs a rebase

@jordwest jordwest force-pushed the update/happychat/fetch-transcripts branch from 0cd121d to 8efddcd Compare March 9, 2017 07:43
@matticbot matticbot added the [Size] M Medium sized issue label Mar 9, 2017
@mattwondra
Copy link
Member

@jordwest Is this PR still relevant? It branches off update/happychat/refactor-with-middleware-2 which was closed in #11604

@jordwest
Copy link
Contributor Author

jordwest commented Mar 23, 2017

This one is still relevant, but will need a few changes/rebasing off master now that some middleware is in place.

@jordwest jordwest added [Status] In Progress and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Mar 24, 2017
@jordwest jordwest changed the base branch from update/happychat/refactor-with-middleware-2 to master March 24, 2017 05:03
@jordwest jordwest force-pushed the update/happychat/fetch-transcripts branch from 8efddcd to 51fc9d3 Compare March 24, 2017 05:10
@jordwest jordwest changed the title Happychat: Persist and fetch transcripts on reload Happychat: Persist transcripts between reloads Mar 24, 2017
@jordwest
Copy link
Contributor Author

This is now ready for testing and review - the scope is reduced and it's much simpler now that the transcript fetching is already working in master.

@jordwest jordwest added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] In Progress labels Mar 24, 2017
@mattwondra mattwondra self-requested a review March 24, 2017 18:32
Copy link
Member

@mattwondra mattwondra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks and works great! I'll plan to 🚢 this for you early next week.

@mattwondra mattwondra added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Mar 24, 2017
@mattwondra mattwondra merged commit b1479af into master Mar 27, 2017
@matticbot matticbot added [Size] M Medium sized issue and removed [Status] Ready to Merge labels Mar 27, 2017
@jordwest jordwest deleted the update/happychat/fetch-transcripts branch April 3, 2017 01:10
@jordwest
Copy link
Contributor Author

jordwest commented Apr 3, 2017

Thanks for looking after this one @mattwondra!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Happychat [Size] M Medium sized issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants