Plans: First pass at adding Jetpack auto-config thank you page #11692
Conversation
ebinnion
added
.org Plans
Jetpack
[Feature] Plans & Upgrades
ebinnion
force-pushed
the
add/first-pass-jetpack-plan-update
branch
from
f830822
to
6f238f4
Compare
matticbot
added
[Size] XL
| } | ||
| ) } | ||
| <NoticeAction href={ manageUrl }> | ||
| { translate( 'Turn On Manage' ) } |
There was a problem hiding this comment.
Hi! I've found a possible matching string that has already been translated 22 times:
translate( 'Turn on remote management' ) ES Score: 9
Help me improve these suggestions: react with 👎 if the suggestion doesn't make any sense, or with 👍 if it's a particularly good one (even if not implemented).
| } else if ( 'akismet' === plugin.slug ) { | ||
| switch ( plugin.status ) { | ||
| case 'done': | ||
| return translate( 'Spam protection active' ); |
There was a problem hiding this comment.
Hi! I've found a possible matching string that has already been translated 27 times:
translate( 'Spam Protection' ) ES Score: 9
See 2 additional suggestions in the PR translation status page
Help me improve these suggestions: react with 👎 if the suggestion doesn't make any sense, or with 👍 if it's a particularly good one (even if not implemented).
| ) } | ||
| > | ||
| <NoticeAction href={ manageUrl }> | ||
| { translate( 'Turn On Manage' ) } |
There was a problem hiding this comment.
Hi! I've found a possible matching string that has already been translated 22 times:
translate( 'Turn on remote management' ) ES Score: 9
Help me improve these suggestions: react with 👎 if the suggestion doesn't make any sense, or with 👍 if it's a particularly good one (even if not implemented).
ebinnion
force-pushed
the
add/first-pass-jetpack-plan-update
branch
from
85fcc1a
to
7ecf79d
Compare
matticbot
added
the
[Size] XL
ebinnion
added
[Status] Needs Review
| import { fetchPluginData } from 'state/plugins/wporg/actions'; | ||
| import { requestSites } from 'state/sites/actions'; | ||
| import { | ||
| installPlugin, |
There was a problem hiding this comment.
this could go inline with import :)
| } | ||
|
|
||
| allPluginsHaveWporgData() { | ||
| const plugins = this.addWporgDataToPlugins( this.props.plugins ); |
There was a problem hiding this comment.
maybe we shouldn't call addWporgDataToPlugins from allPluginsHaveWporgData
There was a problem hiding this comment.
We may not need the wporg plugins data any longer since we're currently just using the plugin slug. I believe that's a holdover from the old UI where we wanted to show the plugin icon and the plugin name. I'll look into that in future iterations.
|
looks good for a first iteration |
lezama
added
[Status] Ready to Merge
and removed
[Status] Needs Review
This PR is meant to add the auto-config functionality below the
PlanThankYouCardblock. This PR is functional at this point, but needs a lot more polish before this feature can be finished. I'd like to get the PR in now since it's already getting large and it'll help with review.Much of the functionality is copied from the
jetpack-plugins-setup.jsxcomponent. That is not ideal. In the future, once I polish everything and finish the functionality, I'd like to maybe create a data component that handles fetching and deciding when to move from plugin to plugin. Then, I can pass that as props down to thejetpack-plugins-setup.jsxcomponent and this new component.But, I'd rather finish this before I start making decisions about the data component.
This functionality is behind a feature flag, so there shouldn't be any issue with merging.
To test:
You'll want to go to
/checkout/thank-you/$site/$receiptwhere$siteis a Jetpack site ID and$receiptis a recent purchase for a Jetpack plan.You'll need to have Jetpack connected and active, and then this should install/activate VaultPress and/or Akismet. You can verify this in wp-admin afterwards.
cc @lezama @ryelle for review and thoughts on the approach.