Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Independent Publisher w/ IP2 in signup #12996

Merged
merged 1 commit into from Apr 11, 2017
Merged

Replace Independent Publisher w/ IP2 in signup #12996

merged 1 commit into from Apr 11, 2017

Conversation

sixhours
Copy link
Contributor

I'm unsure how to test this, since it appears the theme isn't associated with a particular theme style (blog, grid, page) in signup.

Any ideas what the themes do if they're not listed as one of those three types? Are they ignored?

/cc @michaeldcain

@sixhours sixhours added [Feature] Signup & Account Creation All screens and flows for making a new WordPress.com account. [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Apr 11, 2017
@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=update-themes-in-signup-independent-publisher-2

@matticbot matticbot added the [Size] S Small sized issue label Apr 11, 2017
michaeldcain
michaeldcain approved these changes Apr 11, 2017
View reviewed changes
Copy link
Member

@michaeldcain michaeldcain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any ideas what the themes do if they're not listed as one of those three types? Are they ignored?

Yes, they're just ignored, although it's a decent list of themes that could be included, so it's worth updating.

This LGTM!

@sixhours sixhours merged commit ac7c77a into master Apr 11, 2017
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 11, 2017
@sixhours sixhours deleted the update-themes-in-signup-independent-publisher-2 branch April 11, 2017 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaeldcain michaeldcain michaeldcain approved these changes

Assignees
No one assigned
Labels
[Feature] Signup & Account Creation All screens and flows for making a new WordPress.com account. [Size] S Small sized issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sixhours @matticbot @michaeldcain