Domains: Remove componentWillReceiveProps siteId checks in MapDomain #13399
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #12943 we introduced a
siteId
check in thecomponentWillReceiveProps
method ofMapDomain
to avoid unnecessary renders. As @nb mentioned in #12943 (comment), it's possible that the site's upgradeable status can change, and the component should react accordingly to that. Since there might be other edge cases we might have to account for, let's just remove this check for now.To test this, let's let's just make sure everything works properly:
hello world
triggers an error message.nintendo.com
works and brings you to checkout with a domain mapping item added to your cartdjoafeeafw.com
shows you the option to purchase it and brings you to checkout when you click on Select.