Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domains: Remove componentWillReceiveProps siteId checks in MapDomain #13399

Merged
merged 1 commit into from
Apr 27, 2017

Conversation

tyxla
Copy link
Member

@tyxla tyxla commented Apr 26, 2017

In #12943 we introduced a siteId check in the componentWillReceiveProps method of MapDomain to avoid unnecessary renders. As @nb mentioned in #12943 (comment), it's possible that the site's upgradeable status can change, and the component should react accordingly to that. Since there might be other edge cases we might have to account for, let's just remove this check for now.

To test this, let's let's just make sure everything works properly:

  • Load the branch locally and visit http://calypso.localhost:3000/domains/add/mapping/:siteSlug.
  • Verify that entering an invalid domain name such as hello world triggers an error message.
  • Verify that entering a valid and taken domain name such as nintendo.com works and brings you to checkout with a domain mapping item added to your cart
  • Verify that entering a valid and available domain name such as djoafeeafw.com shows you the option to purchase it and brings you to checkout when you click on Select.
  • Check that switching site while on this page works as expected.

@tyxla tyxla added [Feature Group] Emails & Domains Features related to email integrations and domain management. [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Type] Janitorial labels Apr 26, 2017
@tyxla tyxla self-assigned this Apr 26, 2017
@tyxla tyxla requested review from nb and Tug April 26, 2017 06:20
@matticbot matticbot added the [Size] S Small sized issue label Apr 26, 2017
@matticbot
Copy link
Contributor

@nb nb added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Apr 26, 2017
@tyxla tyxla merged commit 8e55faf into master Apr 27, 2017
@tyxla tyxla deleted the update/map-domain-remove-willreceiveprops-checks branch April 27, 2017 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature Group] Emails & Domains Features related to email integrations and domain management. [Size] S Small sized issue [Type] Janitorial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants