Signup: Verticals Survey: Fix redirect-after-survey bug #1449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1310 The redirect was happening because in some browsers (iOS Chrome, Mac OS Firefox) the `#` href in the `Card` components was redirecting the user back to the survey step after the click handler had moved on to the next signup step. The `#` href is necessary to force the `Card` components to display as clickable. This fixes the issue by calling `preventDefault` and `stopPropagation` in the click handler.
sirbrillig
added
[Status] Needs Review
|
ping @kwight for review |
|
LGTM! 👍 |
sirbrillig
added
[Status] Ready to Merge
and removed
[Status] Needs Review
sirbrillig
added a commit
that referenced
this pull request
Dec 10, 2015
Signup: Verticals Survey: Fix redirect-after-survey bug
This was referenced Jul 10, 2020
This was referenced Aug 17, 2020
This was referenced Aug 28, 2020
This was referenced Oct 20, 2020
This was referenced Dec 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1310
The redirect was happening because in some browsers (iOS Chrome, Mac OS Firefox)
the
#href in theCardcomponents was redirecting the user back to thesurvey step after the click handler had moved on to the next signup step. The
#href is necessary to force theCardcomponents to display as clickable.This fixes the issue by calling
preventDefaultandstopPropagationin theclick handler.
Testing
surveycomponent, or find one in the recent history (before Signup: Verticals Survey: Disable the Verticals Survey #1445 was merged). This may be done for you, depending on if checking out this branch works correctly.oneSteptest by entering this into your console:localStorage.setItem( 'ABTests', "{'verticalSurvey_20151202':'oneStep'}" );. Then reload the page to make sure you see the survey.themes) and stay there (previously you would be bounced back to the survey step)