CurrentSite: fix loading state. #1609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtias
added
Sites
[Status] Needs Review
| { hasOneSite | ||
| ? this.addNewWordPressButton() | ||
| : <span className="current-site__switch-sites" /> | ||
| : <span className="current-site__switch-sites"> </span> |
There was a problem hiding this comment.
Wouldn't React render this as plain-text ? Should this be a space character instead?
There was a problem hiding this comment.
It's rendering it fine for me.
There was a problem hiding this comment.
@aduth you can insert HTML entities within literal text in JSX, the problem is if you wrap it in { }
There was a problem hiding this comment.
Huh... I wasn't sure, disabled javascript during this state to inspect to see what happens, and it renders as a space.
There was a problem hiding this comment.
Yep, upon double-checking the docs, @mtias is right and this only affects dynamic content - https://facebook.github.io/react/docs/jsx-gotchas.html#html-entities
|
|
rralian
added
[Status] Ready to Merge
and removed
[Status] Needs Review
lancewillett
removed
the
[Status] Needs Design Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
