Offline: Add default empty cached requests file #20934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although there were no actual breakages, with the introduction of #20688 we started getting a warning from webpack that `cached-requests.json` didn't exist, if indeed there were no cache file already. This commit just makes sure that file exists so that there's no warning.
dmsnell
added
Framework
[Status] Needs Review
deBhal
approved these changes
Dec 19, 2017
|
As an aside (purely because I didn't realize this happened), the bundle warnings were being propagated to the browser too: This PR fixes that too, of course. |
matticbot
removed
the
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although there were no actual breakages, with the introduction of #20688
we started getting a warning from webpack that
cached-requests.jsondidn't exist, if indeed there were no cache file already.
This commit just makes sure that file exists so that there's no warning.
Testing
Build locally. In master you should find a warning about the missing
file but in this branch that warning should be gone.