Editor External Media Google Photos: add date filters #25737
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add both a config feature flag and prop to determine whether to show the Date Filters. Append `?flags=external-media/google-photos/date-filters` to enable the feature for testing
Updates DatePicker component to allow for usage of selectedDays and to show more than 1 month at a time. MediaDateRange component can now take advantage of this functionality to enable a date-range style picker.
…uld be displayed Previously props which determine whether the previous and next nav buttons should be displayed were ignored. Minor modification to take account of this prior to rendering the buttons
Previously DatePicker component was missing support for toMonth, fromMonth and selectedDays props. This limited ability of consumers of DatePicker component to utilise features of React Day Picker library. Particularly useful if you need to create a range picker. See http://react-day-picker.js.org/examples/selected-range
Previously component render was one huge method. Refactored to several smaller utliity methods to make main render more concise.
# Conflicts: # package.json
|
Closing in favour of direct PR to Automattic repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a dropdown with the ability to filter the media list by a given date range.
As discussed at
#25583